Skip to content

XTGETTCAP: Fix DCS response for empty capabilities#8304

Closed
julio-b wants to merge 1 commit into
kovidgoyal:masterfrom
julio-b:fixdcs
Closed

XTGETTCAP: Fix DCS response for empty capabilities#8304
julio-b wants to merge 1 commit into
kovidgoyal:masterfrom
julio-b:fixdcs

Conversation

@julio-b

@julio-b julio-b commented Feb 8, 2025

Copy link
Copy Markdown

Hi, i discovered this bug recently.

  • Steps to reproduce
    $ printf '\eP+q2531\e\\\eP+q2638\e\\\eP+q4b34\e\\\eP+q4b35\e\\' ; cat -v
    ^[P1+r2531^[\^[P1+r2638^[\^[P1+r4b34^[\^[P1+r4b35^[\
  • Expected response
    One of the following:
    ^[P1+r2531=^[\^[P1+r2638=^[\^[P1+r4b34=^[\^[P1+r4b35=^[\
    ^[P0+r2531^[\^[P0+r2638^[\^[P0+r4b34^[\^[P0+r4b35^[\
    ^[P0+r^[\^[P0+r^[\^[P0+r^[\^[P0+r^[\

I was able to bisect this to commit 2bfeb13, which seems to handle empty tcaps and boolean tcaps in the same way.

@kovidgoyal kovidgoyal closed this in af917e6 Feb 8, 2025
zchee pushed a commit to zchee/kitty that referenced this pull request Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant