Skip to content

Add support for sha1 hashes to the hint kitten #604

Merged
kovidgoyal merged 3 commits into
kovidgoyal:masterfrom
ricci:master
Jun 5, 2018
Merged

Add support for sha1 hashes to the hint kitten #604
kovidgoyal merged 3 commits into
kovidgoyal:masterfrom
ricci:master

Conversation

@ricci

@ricci ricci commented Jun 4, 2018

Copy link
Copy Markdown
Contributor

This is specifically intended for git commit hashes, so it allows for
hashes as short as 7 characters (git's default length for abbreviated
hashes) up to the full 40 characters

ricci added 2 commits June 4, 2018 14:25
This is specifically intended for git commit hashes, so it allows for
hashes as short as 7 characters (git's default length for abbreviated
hashes) up to the full 40 characters
@max-baz

max-baz commented Jun 4, 2018

Copy link
Copy Markdown
Contributor

Maybe name it more generically "hash", and allow length up to 128 (for sha512)?

@ricci

ricci commented Jun 4, 2018

Copy link
Copy Markdown
Contributor Author

@maximbaz I'd be up for that. I was just trying to scratch one specific itch, but I agree that it will be trivial to support other use cases

@kovidgoyal
kovidgoyal merged commit da6ad5d into kovidgoyal:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants