Fixed marks grouping and coloring for simultaneous multi marks definition#2663
Merged
Conversation
Contributor
Author
|
Super fast merge 🚀 😺 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with multiple simultaneous mark groups defined. The issue exists on a latest Kitty version and on top of the master branch. If I try to define several marks simultaneously in any available approach I got a text colored just by one color and that color just corresponds to a first mark group in the making definition.
Steps to reproduce:
echo -e 'WARN\nERROR\nFAIL'kitty @ create-marker regex 1 FAIL 2 ERR 3 WARNAll three words should have different colors but all of them just colored as the
FAILword by the color of the first group in the applied marking definition.Bellow screenshots demonstrate the issue:
With the PR fix:
P.S: And thanks for the great project! 🚀