Repository navigation
Conversation
The post-login redirect only rejected targets starting with lowercase 'http', so '//evil.com', 'HTTP://evil.com' and '/\evil.com' redirected users off-site. Only same-site absolute paths are now accepted (any scheme or netloc, protocol-relative and backslash variants fall back to '/'). The login page's client-side validateURL applies the same rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
npm audit fix plus bumps of vue (^3.5.44) and vitest / @vitest/coverage-v8 (^4.1.11) within their current majors. Clears advisories in axios, dompurify, @vue/server-renderer, nanoid, postcss, source-map-js and @vitest/mocker; npm audit now reports 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where these changes come from
Both changes are new work in this PR, not ports from upstream. They came out of a security review of this fork.
startswith('http')check dates from bugy0434941(2018), and the client-sidevalidateURL()has the same gap62bd38a(2026-08-21)Summary
Open redirect after login
TornadoAuthonly rejected anexttarget that started with lowercasehttp, so a crafted login link could send users off-site after they logged in:nextvalue//evil.comhttp://evil.com/HTTP://evil.comhttp://evil.com//\evil.com/\as////index.html/index.html/index.htmlsanitize_next_path()insrc/auth/tornado_auth.pyaccepts only same-site absolute paths (no scheme, no netloc, no backslashes, no//prefix); anything else falls back to/.validateURL()inweb-src/src/login/login.jsapplies the same rule on the client (it previously passed through anyhttp…URL).Dependency vulnerabilities
npm audit fix, plusvue→^3.5.44andvitest/@vitest/coverage-v8→^4.1.11(same majors). Clears the advisories in axios, dompurify, @vue/server-renderer, nanoid, postcss, source-map-js and @vitest/mocker;npm auditnow reports 0 vulnerabilities.Testing
src/tests/auth/test_tornado_auth_redirect.py(18 cases).pytest tests/passes (1752 tests).vitest runpasses (1048 tests);npm run buildclean.nextvalue; all redirect to/, legitimate paths still work.🤖 Generated with Claude Code