Build on node 9 on Circle by SimenB · Pull Request #4851 · jestjs/jest

SimenB · 2017-11-07T06:26:41Z

Summary
Node 9 is out, we should test on it.

Thoughts on doing full CI run on node 8, and partial on node 6? Node 8 is LTS now, and it should speed up the build somewhat

Test plan
Green CI

codecov-io · 2017-11-07T06:37:59Z

Codecov Report

Merging #4851 into master will decrease coverage by 0.57%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master    #4851      +/-   ##
==========================================
- Coverage   60.74%   60.16%   -0.58%     
==========================================
  Files         198      198              
  Lines        6605     6620      +15     
  Branches        3        3              
==========================================
- Hits         4012     3983      -29     
- Misses       2593     2637      +44

Impacted Files	Coverage Δ
packages/jest-cli/src/generate_empty_coverage.js	`85.71% <ø> (ø)`	⬆️
packages/jest-runner/src/test_worker.js	`0% <0%> (ø)`	⬆️
packages/jest-cli/src/reporters/coverage_worker.js	`81.81% <100%> (+31.81%)`	⬆️
...ckages/jest-cli/src/reporters/coverage_reporter.js	`65.38% <5.26%> (-0.76%)`	⬇️
packages/jest-runner/src/index.js	`38.29% <50%> (+0.52%)`	⬆️
packages/jest-snapshot/src/index.js	`43.18% <0%> (-19.87%)`	⬇️
packages/jest-cli/src/pre_run_message.js	`66.66% <0%> (-16.67%)`	⬇️
packages/jest-util/src/index.js	`88.23% <0%> (-2.25%)`	⬇️
packages/jest-runtime/src/script_transformer.js	`85.35% <0%> (-1.48%)`	⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ed471...9c6f33b. Read the comment docs.

SimenB · 2017-11-07T08:15:20Z

Huh, weird failure

cpojer · 2017-11-07T09:03:05Z

Seems like assert's error was changed with node 9, so we have to make test work with both the old and new version.

SimenB · 2017-11-08T10:51:35Z

Ergh, unsure about the failure now. Seems like it just hung?

thymikee · 2017-11-22T18:01:52Z

+
+  // Node 9 started to include the error for `doesNotThrow`
+  // https://github.com/nodejs/node/pull/12167
+  if (Number(process.versions.node.split('.')[0]) >= 9) {


Not a fan of this, but can live with it. Worth to refactor this test one day though.

thymikee · 2017-11-22T18:09:04Z

I re-ran the job, but locally I can confirm that running tests in parallel on Node 9 holds the Jest process (Node 8 kills it). Not sure if that's Node's fault, because running our test suite with --detectLeaks flag on @mjesun PR #4895 reveals a leak in our codebase (somehow connected with graceful-fs)

SimenB · 2017-11-22T19:12:23Z

Rebased on master and reverted the migration to jest-worker, just to test

SimenB · 2017-11-22T19:55:39Z

Didn't seem to help, hanging on the examples :(

SimenB · 2017-11-22T20:57:49Z

Easy reproduction of the error: ./jest --projects $(pwd)/examples/react-native. This passes on node 8 in 6 sec on my machine, hangs forever on node 9. I don't know why... I'm not sure what the best way to check why the process hangs is. #4895 doesn't help, as the tests never exit

SimenB · 2017-11-27T07:35:30Z

Is it related to react-native somehow? Might be a coincidence, but the linked issue from the node core issue tracker is also react-native. nodejs/node#17040

@cpojer I don't really know how to debug this, so a shot in the dark might be asking some react-native folks at fb if they know of any issues with node 9? Or if you have any ideas on how to figure out what's hanging, it would be much appreciated 🙂

cpojer · 2017-11-27T08:55:11Z

Is this using the latest version of RN? I'm assuming it doesn't reproduce locally?

SimenB · 2017-11-27T12:44:18Z

Running ./jest --projects $(pwd)/examples/react-native locally on node 9 reproduces the error

SimenB · 2017-12-11T15:20:36Z

Rebased now that #5050 is merged, fingers crossed! 🤞

SimenB · 2017-12-11T15:22:45Z

+      Got unwanted exception.
+    err!
+    err!
+


gah, these trailing spaces gets killed every time I rebase, and I keep forgetting to add them back in :P

SimenB · 2017-12-11T15:30:05Z

Node 9 is green, yay!

cpojer · 2017-12-11T15:35:35Z

Awesome!

github-actions · 2021-05-13T01:32:12Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

SimenB requested a review from thymikee November 7, 2017 06:26

facebook-github-bot added the CLA Signed ✔️ label Nov 7, 2017

SimenB force-pushed the node-9 branch 2 times, most recently from 99f79dd to f7d97c5 Compare November 8, 2017 10:11

apapirovski mentioned this pull request Nov 20, 2017

Node Jest Snapshot testing hangs forever nodejs/node#17040

Closed

thymikee reviewed Nov 22, 2017

View reviewed changes

thymikee approved these changes Nov 22, 2017

View reviewed changes

SimenB force-pushed the node-9 branch from 4252f20 to d613e45 Compare November 22, 2017 19:10

SimenB force-pushed the node-9 branch from 3d209e7 to add7dc3 Compare November 22, 2017 19:42

SimenB force-pushed the node-9 branch from add7dc3 to 8d675bf Compare November 22, 2017 19:56

SimenB mentioned this pull request Dec 9, 2017

assert: use Object.is comparison in .strictEqual nodejs/node#17003

Closed

4 tasks done

SimenB added 3 commits December 11, 2017 16:19

Build on node 9 on Circle

6c9756d

Actually trigger node 9 buid as well

743749b

Run full ci on node 8 instead of node 6

78bf1b9

SimenB force-pushed the node-9 branch from 8d675bf to c92487e Compare December 11, 2017 15:19

Fix test for node 9

9c6f33b

SimenB force-pushed the node-9 branch from c92487e to 9c6f33b Compare December 11, 2017 15:22

SimenB commented Dec 11, 2017

View reviewed changes

cpojer merged commit 78741aa into jestjs:master Dec 11, 2017

SimenB deleted the node-9 branch December 11, 2017 15:35

github-actions Bot locked as resolved and limited conversation to collaborators May 13, 2021

Conversation

SimenB commented Nov 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Nov 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

SimenB commented Nov 7, 2017

Uh oh!

cpojer commented Nov 7, 2017

Uh oh!

SimenB commented Nov 8, 2017

Uh oh!

thymikee Nov 22, 2017

Choose a reason for hiding this comment

Uh oh!

thymikee commented Nov 22, 2017

Uh oh!

SimenB commented Nov 22, 2017

Uh oh!

SimenB commented Nov 22, 2017

Uh oh!

SimenB commented Nov 22, 2017

Uh oh!

SimenB commented Nov 27, 2017

Uh oh!

cpojer commented Nov 27, 2017

Uh oh!

SimenB commented Nov 27, 2017

Uh oh!

SimenB commented Dec 11, 2017

Uh oh!

SimenB Dec 11, 2017

Choose a reason for hiding this comment

Uh oh!

SimenB commented Dec 11, 2017

Uh oh!

cpojer commented Dec 11, 2017

Uh oh!

github-actions Bot commented May 13, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

SimenB commented Nov 7, 2017 •

edited

Loading

codecov-io commented Nov 7, 2017 •

edited

Loading