Inform model about node's position change

paceholder · paceholder · commit f468862a847d · 2022-11-28T15:11:18.000+01:00
diff --git a/examples/graph/CustomGraphModel.cpp b/examples/graph/CustomGraphModel.cpp
@@ -226,7 +226,7 @@ setNodeData(NodeId   nodeId,
     {
       _nodeGeometryData[nodeId].pos = value.value<QPointF>();
 
-      Q_EMIT nodePositonUpdated(nodeId);
+      Q_EMIT nodePositionUpdated(nodeId);
 
       result = true;
     }
diff --git a/include/nodes/internal/AbstractGraphModel.hpp b/include/nodes/internal/AbstractGraphModel.hpp
@@ -177,7 +177,7 @@ class NODE_EDITOR_PUBLIC AbstractGraphModel : public QObject
   nodeDeleted(NodeId const nodeId);
 
   void
-  nodePositonUpdated(NodeId const nodeId);
+  nodePositionUpdated(NodeId const nodeId);
 
   void
   portDataSet(NodeId const    nodeId,
diff --git a/src/BasicGraphicsScene.cpp b/src/BasicGraphicsScene.cpp
@@ -50,7 +50,7 @@ BasicGraphicsScene(AbstractGraphModel &graphModel,
   connect(&_graphModel, &AbstractGraphModel::nodeDeleted,
           this, &BasicGraphicsScene::onNodeDeleted);
 
-  connect(&_graphModel, &AbstractGraphModel::nodePositonUpdated,
+  connect(&_graphModel, &AbstractGraphModel::nodePositionUpdated,
           this, &BasicGraphicsScene::onNodePositionUpdated);
 
   connect(&_graphModel, &AbstractGraphModel::portsAboutToBeDeleted,
diff --git a/src/DataFlowGraphModel.cpp b/src/DataFlowGraphModel.cpp
@@ -285,7 +285,7 @@ setNodeData(NodeId   nodeId,
     {
       _nodeGeometryData[nodeId].pos = value.value<QPointF>();
 
-      Q_EMIT nodePositonUpdated(nodeId);
+      Q_EMIT nodePositionUpdated(nodeId);
 
       result = true;
     }
diff --git a/src/NodeGraphicsObject.cpp b/src/NodeGraphicsObject.cpp
@@ -352,6 +352,7 @@ mouseMoveEvent(QGraphicsSceneMouseEvent * event)
       _proxyWidget->setMaximumSize(oldSize);
       _proxyWidget->setPos(geometry.widgetPosition());
 
+      // Passes the new size to the model.
       geometry.recalculateSize();
 
       update();
@@ -365,10 +366,7 @@ mouseMoveEvent(QGraphicsSceneMouseEvent * event)
   {
     QGraphicsObject::mouseMoveEvent(event);
 
-    if (event->lastPos() != event->pos())
-      moveConnections();
-
-    event->ignore();
+    _graphModel.setNodeData(_nodeId, NodeRole::Position, pos());
   }
 
   QRectF r = nodeScene()->sceneRect();

Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,7 @@ setNodeData(NodeId nodeId,`
`226`	`226`	`{`
`227`	`227`	`_nodeGeometryData[nodeId].pos = value.value<QPointF>();`
`228`	`228`
`229`		`- Q_EMIT nodePositonUpdated(nodeId);`
	`229`	`+ Q_EMIT nodePositionUpdated(nodeId);`
`230`	`230`
`231`	`231`	`result = true;`
`232`	`232`	`}`
Original file line number	Diff line number	Diff line change
`@@ -285,7 +285,7 @@ setNodeData(NodeId nodeId,`
`285`	`285`	`{`
`286`	`286`	`_nodeGeometryData[nodeId].pos = value.value<QPointF>();`
`287`	`287`
`288`		`- Q_EMIT nodePositonUpdated(nodeId);`
	`288`	`+ Q_EMIT nodePositionUpdated(nodeId);`
`289`	`289`
`290`	`290`	`result = true;`
`291`	`291`	`}`