Fix issue #1003#1004
Merged
Merged
Conversation
Member
|
Great job, thanks for this, it's much nicer parsing the xml than purely using regexes everywhere |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #1003
Problem
For the VB to CS project file conversion,
<DefineDebug>and<DefineTrace>should be converted to<DefineConstants>.Solution
XDocumentto parse and edit the XML (this is already used elsewhere in the codebase, e.g. to parse the resource files).<DocumentationFile>conversion).XDocumentstep can cause minor changes in formatting (this can be seen in the updated test files), but I don't think this is an issue (they are new files generated by the converter, not existing files).MultiFileTestFixtureto ouput the expected file path in case of failure.