Skip to content

Fixes in documentation - #121

Merged
catmando merged 1 commit into
hyperstack-org:edgefrom
Tim-Blokdijk:edge
Feb 11, 2019
Merged

catmando merged 1 commit into
hyperstack-org:edgefrom
Tim-Blokdijk:edge

Conversation

@Tim-Blokdijk

Copy link
Copy Markdown
Contributor

A lot more body in CONTRIBUTING.md
More polish for the installation instructions.
Other documentation thingies.

More polish for the installation instructions.
@catmando
catmando merged commit c0178e2 into hyperstack-org:edge Feb 11, 2019
mpantel pushed a commit to mpantel/hyperstack that referenced this pull request Sep 2, 2026
mpantel added a commit to mpantel/hyperstack that referenced this pull request Sep 2, 2026
mpantel added a commit to mpantel/hyperstack that referenced this pull request Sep 2, 2026
CI: drop the hyper-trace test job, which ran zero specs (hyperstack-org#121)

Closes hyperstack-org#121

See merge request ru/hyperstack!165
mpantel added a commit to mpantel/hyperstack that referenced this pull request Sep 2, 2026
…yperstack-org#121)

The test-job assertion added in !165 scanned for `extends: .test_gem*`
followed directly by `variables:` and then `COMPONENT:`. hyperstack-org#116 landed on edge
in between and put an explanatory comment between `variables:` and
`COMPONENT:` in the hyper-i18n job, so the regex stopped matching it:

  hyperstack:gem:check FAILED — published but no test job, and not listed
  in UNTESTED_BY_CI: hyper-i18n

That fails `supported-versions` on every pipeline, which is exactly the
"blocks everything" failure a gate must not have. It is live on edge now,
hence this fix rather than a revert.

The bug was the method, not the pattern: whitespace and comments are things
YAML is entitled to ignore, so a check that reads meaning out of layout will
keep breaking as the file is edited. This asks the parser instead --
`YAML.safe_load(aliases: true)`, take the top-level keys that are jobs (not
`.`-prefixed templates), keep the ones whose `extends` names a `.test_gem*`
template, read `variables.COMPONENT`. The file has no `!reference` tags, so
plain safe_load is sufficient.

Verified against edge's current .gitlab-ci.yml: OK with 10 tested gems; still
fails when a hyper-trace test job is re-added (including with a comment
between the keys, the shape that broke it); still fails when hyper-router's
job is deleted.

Note the pre-existing `.deploy_gem` scan just above has the same latent
fragility. Left alone deliberately -- it works today and edge is broken right
now -- but it is worth converting to the same parse next time this file is
touched.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F7Moi3oFZzMWWahDTi3sRo
mpantel added a commit to mpantel/hyperstack that referenced this pull request Sep 2, 2026
CI: parse .gitlab-ci.yml in gem:check instead of pattern-matching it (hyperstack-org#121)

See merge request ru/hyperstack!166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants