You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Hyper model's while_loading does not work when loading scopes #67
# add this to the while_loading spec, and watch it fail!
...
FactoryBot.create(:user,first_name: 'Lily',last_name: 'DaDog')FactoryBot.create(:user,first_name: 'Coffee',last_name: 'Boxer')
...
it"while loading works with relationships"doReactiveRecord::Operations::Fetch.semaphore.synchronizedomount"WhileLoadingTester",{},no_wait: truedoclassMyComponent < HyperComponentrenderdoSPAN{'loading...'}endendclassWhileLoadingTester < HyperComponentrenderdoULdoUser.each{ |user| LI{user.last_name}}end.while_loading'loading...'endendendexpect(page).tohave_content('loading...')expect(page).not_tohave_content('DaDog',wait: 0)endexpect(page).tohave_content('DaDog')expect(page).not_tohave_content('loading...',wait: 0)end
changed the title [-]Hyper model's `while_loading` does not work when loading scopes[/-][+]Hyper model's `while_loading` does not work with loading scopes[/+]on Nov 20, 2018
changed the title [-]Hyper model's `while_loading` does not work with loading scopes[/-][+]Hyper model's `while_loading` does not work when loading scopes[/+]on Nov 20, 2018
Activity
catmando commentedon Nov 19, 2018
problem is that the WhileLoading assumes the number of loaded children stays constant. In this case it does not!
[-]Hyper model's `while_loading` does not work when loading scopes[/-][+]Hyper model's `while_loading` does not work with loading scopes[/+][-]Hyper model's `while_loading` does not work with loading scopes[/-][+]Hyper model's `while_loading` does not work when loading scopes[/+]catmando commentedon Jan 15, 2019
closed as part of changing while loading to use error boundries (it also fixed in the deprecated while_loading code, but who cares)
Keep the first evaluation eager (hyperstack-org#67)
Merge branch 'fix/expect-evaluate-ruby-wait' into 'edge'
specs: stop asserting exact values the polled block itself mutates (h…