More concisedom_node and ref handling for jquery

currently you can grab a components ref mapped to jquery using the dom keyword:

INPUT(dom: set(:_input) ... )

it works just like ref, but the resulting value is wrapped by jQuery.

however if you say self.dom_node you get your own ref, and if you want jQuery you say DOM[dom_node]

Seems not very symmetrical.

I am suggesting we do something like this:

dom keyword -> jQuery wrapped reference
ref keyword -> reference

self.dom -> jQuery wrapped reference to self
self.ref -> straight dom reference to self.

and that is the problem ... its sort of backwards.

So alternative proposal:

dom keyword is synonym for ref
jq keyword is ref/dom wrapped by jquery

likewise self.dom is ref to yourself and
self.jq is your self wrapped by jquery

Any other ideas for a pair of names that could be used consistently in both places?

Seems odd that self.dom gives you a ref - why not:

self.dom_ref gives you a ref to self
self.jq_dom_ref gives you a jQuery dom to self

ie just be explicit?

cause I hate typing

but perhaps these are obscure enough to warrant the extra typing?

how about dom_ref and jq_ref for the keys, and dom_node and jq_node for the methods?

@catmando

That sounds great @catmando I will remember that :-)

step 1 in fixing #62

so I went around and around on this.

In the end I am leaving ref working the same as react's ref (i.e. it takes a callback which is sent the dom_node of the mounted component.

then there is a the set method which is part of the Observable module. This creates a lambda which sets an instance variable.

Together you can then say: ref: set(:foo) to set the @foo to the ref.

Meanwhile DOM is now changed to the shorter, and easier to understand JQ class to wrap jQuery.

So you could then say JQ[@foo] to get the jquery wrapped node.

You can also say JQ[dom_node] to get your own dom_node wrapped by jQuery.

Finally there is a set_jq method which works like set but wraps the node in jQuery for you like this:

ref: set_jq(:foo)

Summary:

there is one special key in a components parameter list: ref which takes a callback argument.
there is a helper method set which is part of the Observable module
components continue to have the dom_node instance method
if you are using jquery then set_jq is added

adds specs and closes #62

updated change log. Improved #62

Summary:

In order to get a reference to a component add the special ref keyword to a components param list. The value of the param must be a proc which will receive the dom node. For example:

DIV(ref: ->(node) { puts "Hey my inner text is #{`#{node}.innerText` }) { "ho ho ho" }
# puts `ho ho ho` to the console

Because often you want to save the node in an instance variable the Observable mixin provides the set method which will set the provided instance variable to the value of the dom node.

#  @the_div will contain the dom node of the div once the `DIV` has been mounted.
DIV(ref: set(:the_div)) { "click me" }.on(:click) { alert("I said #{`#{@the_div}.innerText`") }
# alerts `click me`

If you are using jQuery you can access the jQuery API though the global jQ method:

 DIV(ref: set(:the_div)) { "click me" }.on(:click) { alert("I said #{jQ[@the_div].text}") }

See opal-jquery for details on the the Opal jQuery wrapper, just note that Element is replaced by the jQ as Element conflicts with the React Element wrapper.

Finally if you are using jQuery you can replace the set method by set_jq which will set the instance variable to the dom node wrapped by jQuery.

 DIV(ref: set_jq(:the_div)) { "click me" }.on(:click) { alert("I said #{@the_div.text") }

step 1 in fixing hyperstack-org#62

adds specs and closes hyperstack-org#62

updated change log. Improved hyperstack-org#62

Fix hyperstack-org#62: an uncontrolled <textarea> must ignore later v…

Merge branch 'fix/issue-62-uncontrolled-textarea' into 'edge'

Navigation Menu

Repository navigation

More concise`dom_node` and `ref` handling for jquery #62

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

More concisedom_node and ref handling for jquery #62

Description

Activity

barriehadfield commented on Nov 16, 2018

catmando commented on Nov 18, 2018

catmando commented on Nov 19, 2018

barriehadfield commented on Nov 19, 2018

catmando commented on Jan 16, 2019

catmando commented on Jan 17, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

More concise`dom_node` and `ref` handling for jquery #62