Skip to content

rails generator and react import misleading #347

Closed

Description

@catmando

Rails generator leaves this line in hyperstack.rb

Hyperstack.cancel_import 'react/react-source-browser' # bring your own React and ReactRouter via Yarn/Webpacker

This is misleading. Latest Hyperstack does not import react/react-source-browser, so commenting this out, does nothing.

Instead this should read:

# Hyperstack.import 'react/react-source-browser' # uncomment this line if you want hyperstack to bring its copy of react

Activity

  1. added
    compatibilitycompatibility with dependencies such as Rails, Opal, React, etc. NOT FUNCTIONAL COMPATIBILITY
    needs docEverything is working, but documentation is needed.
    on Feb 11, 2021
  2. added a commit that references this issue on Feb 20, 2021
    5bb9541
  3. added
    ready-to-releaseInternal Use Only: Has been fixed, specs passing and pushed to edge branch
    and removed
    needs docEverything is working, but documentation is needed.
    on Mar 15, 2021
  4. added a commit that references this issue on Sep 2, 2026
    b3396f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compatibilitycompatibility with dependencies such as Rails, Opal, React, etc. NOT FUNCTIONAL COMPATIBILITYready-to-releaseInternal Use Only: Has been fixed, specs passing and pushed to edge branch

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions