Skip to content

Hyperstack.send_message needs timeout #144

Closed

Description

@catmando

Hyperstack.send_to_server will cleanly drop messages on the floor if the server is not up, but relies on getting back an HTTP error code (i.e. 504). There are cases that due to setup problems with the server unrelated to Hyperstack, the request to the server may simply hang.

This causes Hyperstack.send_to_server to propagate a timeout error back up the system, which crashes the whole console (for example.)

This makes debugging the unrelated server problem difficult.

What we need to do is wrap send_to_server in a configurable timeout that will cleanly drop the message.

While we are at it, setting the configurable timeout to a negative value should simply drop the value, while 0 and nil should ignore the time out.

Activity

  1. added this to the alpha1.5 milestone on Mar 25, 2019
  2. added a commit that references this issue on Apr 23, 2019
    4e2f2c5
  3. added
    ready-to-releaseInternal Use Only: Has been fixed, specs passing and pushed to edge branch
    on Apr 23, 2019
  4. added a commit that references this issue on Sep 2, 2026
    8400410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestready-to-releaseInternal Use Only: Has been fixed, specs passing and pushed to edge branch

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions