ActiveRecord::Base#new? should be #new_record? #120

Activity

1. catmando

   added

   bugSomething isn't workingSomething isn't working

   enhancementNew feature or requestNew feature or request

   on Jan 29, 2019
2. catmando

   added this to the alpha1.4 milestone on Feb 15, 2019
3. catmando commented on Feb 15, 2019

   

   catmando

   on Feb 15, 2019

   ContributorAuthor

   More actions

   needed to use new? for #117 so this got done with that.
4. catmando commented on Feb 16, 2019

   

   catmando

   on Feb 16, 2019

   ContributorAuthor

   More actions

   I don't see any reason to deprecate. Its just an alias method
5. Tim-Blokdijk commented on Apr 14, 2019

   

   Tim-Blokdijk

   on Apr 14, 2019

   Contributor

   More actions

   Seems to work, issue can be closed.
   Does not need explicit documentation, as it's a ActiveRecord method.
6. catmando

   modified the milestones: alpha1.4, alpha1.5 on Apr 18, 2019
7. catmando

   added

   ready-to-releaseInternal Use Only: Has been fixed, specs passing and pushed to edge branchInternal Use Only: Has been fixed, specs passing and pushed to edge branch

   on Apr 18, 2019
8. catmando

   closed this as completedon Jun 14, 2019
9. mpantel

   added 2 commits that reference this issue on Sep 2, 2026

   esbuild: pin the browser target, and keep sourcemaps out of production (

   ...

   c2bff44

   Merge branch 'feat/issue-120-sourcemap-target' into 'edge'

   ...

   b10c20a