Disable HLE of scePsmf and scePsmfPlayer#20208
Merged
Merged
Conversation
Testing has shown that this seems to work great and fixes issues. These two modules are just a parser and a shim over sceMpeg, and we're better off running the original code, instead of re-implementing it. sceMpeg still needs accuracy improvements though, and it's built on some pretty low level components so it will be harder to peel off the next level of the HLE onion. Se #20200.
Owner
Author
|
Ah, of course this doesn't work with the tests, since for them, there's no library to load. Will need to work around that. |
May later be turned into developer settings, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing has shown that this seems to work great and fixes issues, such as #18094. These two modules are just a parser and a shim over sceMpeg, and we're better off actually loading them and running the original code, instead of re-implementing it through HLE.
sceMpeg still needs accuracy improvements though, and it's built on some pretty low level components so it will be harder to peel off the next level of the HLE onion.
See #20200.
If there are regressions, this is trivial and even quite safe to revert.