Addresses #6165 by removing incorrect and conflicting instruction#6569
Merged
ramyaragupathy merged 1 commit intoOct 23, 2024
Conversation
…on about not using scheme on "next two variables". Second example does indeed include scheme and first example produces an incorrect link without scheme included.
|
mahesh-naxa
approved these changes
Oct 14, 2024
mahesh-naxa
left a comment
Contributor
There was a problem hiding this comment.
thanks for catching this.
royallsilwallz
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes incorrect and conflicting instruction about not using scheme on "next two variables". Second example does indeed include scheme and first example produces an incorrect link without scheme included.
What type of PR is this? (check all applicable)
Related Issue
Example: Fixes #6165
Describe this PR
See above.
Screenshots
Please provide screenshots of the change.
Review Guide
Notes for the reviewer. Probably look at your own variables in production. Barring that, set up a server using these instructions and check the website link in the upper right header; the domain name will appear as a path on the base server domain not as its own domain.
Checklist before requesting a review