Surface Magic-Folder errors#392
Merged
Merged
Conversation
Thereby allowing syncing attempts to momentarily display the "Syncing" text/animation in the Status column, even if they fail shortly after
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the rather basic functionality of collecting any errors observed in Magic-Folder status API messages and propagating them to the user (via the folders view's "Status" column) like so:
Unfortunately, because Magic-Folder presently provides no API for clearing/acknowledging error messages, until further notice, any/all known Magic-Folder errors will persist indefinitely in the Gridsync UI. Expect this to change/improve as Magic-Folder development continues, however...