Improve UI scaling#199
Merged
Merged
Conversation
In case qt5reactor.install() is interfering with this...
Further investigation/testing is required...
0.15 seemingly won't compile with Visual C++ for Python 9.0...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to #193, this PR attempts to address a number of UI scaling-related issues on high-DPI displays. In particular, it:
Enables Qt5's
AA_EnableHighDpiScaling/AA_UseHighDpiPixmapsattributes on Windows and macOS, thereby automatically upscaling window-sizes, font-sizes, and pixmap-sizes according to the underlying display's resolution/DPI.Explicitly sets font point-sizes throughout the codebase (seemingly a requirement for
AA_EnableHighDpiScalingto work properly) and automatically adjusts font point-sizes on macOS to match their equivalent Windows/Linux sizesUses
SmoothTransformationwhen (re)scaling pixmaps, resulting in pixmaps that should appear less "blocky" or "pixelated" at higher resolutions.As mentioned in this comment, however, some issues still remain on GNU/Linux, and so I've disabled
AA_EnableHighDpiScaling/AA_UseHighDpiPixmapsthere for now. See/follow Issue #198 for future progress relating to improving UI scaling on GNU/Linux.