Repository navigation
Conversation
bbakerman
left a comment
There was a problem hiding this comment.
Thanks for this.
There is no major reason for not upgrading - just inertia
We only use Guava for its Immutable collections and we shade everything else out
Test ReportTest Results
Code Coverage (Java 25)
Changed Class Coverage (1 class)
|
|
Thanks for reviewing and merging my PR! I appreciate the feedback and the opportunity to contribute to GraphQL Java. |
|
Is there a timeframe when this will find its way into a new graphql version? The corresponding CVE is of high severity and might indeed be exploited if you're using Java deserialization independent of whether GraphQL itself uses it. |
|
I don't think there is security urgency here: the CVE doesn't actually apply to graphql-java. Guava is shaded, relocated, and minimized in this project. Only the immutable collections survive after minimization, under graphql-java's own namespace. Code that isn't on the classpath can't be reached by a deserialization gadget. If a scanner flags the graphql-java jar against this CVE, that's a false positive. |
|
Correction to my previous comment: some shaded collection classes, including |
|
@bclozel When can we expect the fix version of the CVEs? |
graphql-java 21.5 shades Guava 32.1.2-jre and keeps its Maven metadata (META-INF/maven/com.google.guava), so image scanners report Guava CVEs (e.g. CVE-2026-102554) even though the direct Guava dependency is patched. At package time, build graphql-java-<ver>-stripped.jar without that metadata and exclude the original jar from the WAR and Boot repackage. The relocated classes (graphql/com/google/common, incl. MapMakerInternalMap) are unchanged and remain vulnerable; this silences the scanner only. Remove once graphql-java releases with a patched Guava (graphql-java/graphql-java#4498, #4530, #4536). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
+1 for the release request |
Summary
32.1.2-jreto33.7.2-jreto address CVE-2026-102554.Fixes #4496.
Verification
com.google.guava:guava:33.7.2-jre.clean buildFinalJarcompleted successfully.com/google/common/package path.graphql.parser.MultiSourceReaderTest.can combine filesfails. I reproduced the same failure with both Guava32.1.2-jreand33.7.2-jre, so the failure does not appear to be caused by this dependency update. The full test suite has not passed.