Skip to content

Update Guava to address CVE-2026-102554 - #4498

Merged
bbakerman merged 2 commits into
graphql-java:masterfrom
VelpulaGangavardhan:fix/4496-guava-security-update
Oct 19, 2026
Merged

bbakerman merged 2 commits into
graphql-java:masterfrom
VelpulaGangavardhan:fix/4496-guava-security-update

Conversation

@VelpulaGangavardhan

Copy link
Copy Markdown

Summary

Fixes #4496.

Verification

  • Confirmed Gradle resolves com.google.guava:guava:33.7.2-jre.
  • clean buildFinalJar completed successfully.
  • Verified 839 relocated Guava entries and zero entries under the original com/google/common/ package path.
  • Test status: graphql.parser.MultiSourceReaderTest.can combine files fails. I reproduced the same failure with both Guava 32.1.2-jre and 33.7.2-jre, so the failure does not appear to be caused by this dependency update. The full test suite has not passed.

@bbakerman bbakerman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

There is no major reason for not upgrading - just inertia

We only use Guava for its Immutable collections and we shade everything else out

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Test Report

Test Results

Java Version Total Passed Failed Errors Skipped
Java 11 5982 (±0) 5926 (±0) 0 (±0) 0 (±0) 56 (±0)
Java 17 5982 (±0) 5925 (±0) 0 (±0) 0 (±0) 57 (±0)
Java 21 5982 (±0) 5925 (±0) 0 (±0) 0 (±0) 57 (±0)
Java 25 5982 (±0) 5925 (±0) 0 (±0) 0 (±0) 57 (±0)
jcstress 32 (±0) 32 (±0) 0 (±0) 0 (±0) 0 (±0)
Total 23960 (±0) 23733 (±0) 0 (±0) 0 (±0) 227 (±0)

Code Coverage (Java 25)

Metric Covered Missed Coverage vs Master
Lines 30158 3117 90.6% ±0.0%
Branches 8848 1520 85.3% ±0.0%
Methods 8050 1206 87.0% ±0.0%

Changed Class Coverage (1 class)

Class Line Branch Method
g.e.ExecutionStrategy ±0.0% +0.8% 🟢 ±0.0%

Full HTML report: build artifact jacoco-html-report

Updated: 2026-10-19 05:57:24 UTC

@bbakerman
bbakerman merged commit 4158b45 into graphql-java:master Oct 19, 2026
10 checks passed
@VelpulaGangavardhan

Copy link
Copy Markdown
Author

Thanks for reviewing and merging my PR! I appreciate the feedback and the opportunity to contribute to GraphQL Java.

@ugrepel

ugrepel commented Oct 28, 2026

Copy link
Copy Markdown

Is there a timeframe when this will find its way into a new graphql version?

The corresponding CVE is of high severity and might indeed be exploited if you're using Java deserialization independent of whether GraphQL itself uses it.

@bclozel

bclozel commented Oct 28, 2026

Copy link
Copy Markdown

I don't think there is security urgency here: the CVE doesn't actually apply to graphql-java. Guava is shaded, relocated, and minimized in this project. Only the immutable collections survive after minimization, under graphql-java's own namespace. Code that isn't on the classpath can't be reached by a deserialization gadget.

If a scanner flags the graphql-java jar against this CVE, that's a false positive.

@bclozel

bclozel commented Nov 3, 2026

Copy link
Copy Markdown

Correction to my previous comment: some shaded collection classes, including MapMakerInternalMap, are in the jar. Exploiting them still requires untrusted Java deserialization in the application.

@jeejz

jeejz commented Nov 4, 2026

Copy link
Copy Markdown

@bclozel When can we expect the fix version of the CVEs?

shawnwangnih added a commit to CBIIT/CCDI-Integrated-Backend that referenced this pull request Nov 4, 2026
graphql-java 21.5 shades Guava 32.1.2-jre and keeps its Maven metadata
(META-INF/maven/com.google.guava), so image scanners report Guava CVEs
(e.g. CVE-2026-102554) even though the direct Guava dependency is patched.

At package time, build graphql-java-<ver>-stripped.jar without that
metadata and exclude the original jar from the WAR and Boot repackage.
The relocated classes (graphql/com/google/common, incl.
MapMakerInternalMap) are unchanged and remain vulnerable; this silences
the scanner only. Remove once graphql-java releases with a patched Guava
(graphql-java/graphql-java#4498, #4530, #4536).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@LonwoLonwo

Copy link
Copy Markdown

+1 for the release request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guava CVE-2026-102554

8 participants