Skip to content

Tracking spec change: Implementations may not deprecate a field that the interface hasn't deprecated #3766

Open

Description

@dondonz

Potential spec change coming in to improve validation, ensuring an implementation cannot deprecate a field that the interface hasn't deprecated

This RFC was promoted to RFC 2 (Draft) stage yesterday graphql/graphql-spec#1053.

Activity

  1. added
    keep-openTells Stale Bot to keep PRs and issues open
    on Jan 24, 2025
  2. dondonz commented on Apr 5, 2025

    @dondonz
    MemberAuthor

    This has been approved and will soon get merged into the spec

  3. added a commit that references this issue on Apr 3, 2026
    ef950f0
  4. ybai08 commented on Oct 18, 2026

    @ybai08

    There's a branch ready that adds this check (spec step 2.6) to TypesImplementInterfaces. It covers object→interface and interface→interface, for both SDL-built and code-built schemas. Before opening a PR, though, a question about rollout.

    If it's on by default, it rejects several of the anonymized production schemas in src/test/resources:

    fixture fields deprecated on the implementation but not on the interface
    large-schema-3 11
    large-schema-4 44
    large-schema-5 135
    large-schema-federated-1 92
    large-schema-federated-2 162

    Only large-schema-4 is built by a unit test. The others are used by the JMH benchmarks.

    Should this be on by default, with the fixtures updated in the same PR? Or would you prefer it opt-in, or held for a major version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    keep-openTells Stale Bot to keep PRs and issues openspec-changeTracking GraphQL specification changes

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions