Skip to content

samples: add reservation samples#298

Merged
anguillanneuf merged 3 commits into
mainfrom
reservation
Feb 9, 2022
Merged

samples: add reservation samples#298
anguillanneuf merged 3 commits into
mainfrom
reservation

Conversation

@anguillanneuf

Copy link
Copy Markdown
Contributor

Towards b/213558019
Adding Python samples for the following region tags:

  • pubsublite_create_reservation
  • pubsublite_get_reservation
  • pubsublite_update_reservation
  • pubsublite_list_reservations
  • pubsublite_delete_reservation

Java already added in googleapis/java-pubsublite#1028

@anguillanneuf anguillanneuf requested a review from a team February 8, 2022 23:44
@anguillanneuf anguillanneuf requested a review from a team as a code owner February 8, 2022 23:44
@product-auto-label product-auto-label Bot added api: pubsublite Issues related to the googleapis/python-pubsublite API. samples Issues that are directly related to samples. labels Feb 8, 2022
@snippet-bot

snippet-bot Bot commented Feb 8, 2022

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@hongalex hongalex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the most part LGTM, some issues with license headers and question about project numbers vs IDs

Comment thread samples/snippets/create_lite_reservation_example.py Outdated
Comment thread samples/snippets/create_lite_reservation_example.py

@dandhlee dandhlee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anguillanneuf anguillanneuf merged commit d22d98c into main Feb 9, 2022
@anguillanneuf anguillanneuf deleted the reservation branch February 9, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/python-pubsublite API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants