Conversation
caller9
commented
Feb 15, 2022
Collaborator
- Requires AGP (com.android.tools.build:gradle) 7.1.0 or higher.
- Read from AGP generated dependency protobuf if available, otherwise use placeholder for debug builds.
- Extract POM resolution into utility class.
- Locate Google Play Services artifacts by walking resolved dependencies after resolution.
- Avoid causing unresolved dependencies to be resolved.
- Clean up some potentially unclosed input streams.
- fixes After upgrading to Gradle 7, test dependencies are included in the license metadata #214 fixes I don't see the open source libraries licenses on the release builds with latest versions. Instead seeing This app does not have any open source licenses. #215 fixes getDependencies takes minutes to complete. #200
- Caused by early, recursive dependency resolution.
- fixes getDependencies task prints enormous amount of AmbiguousVariantSelectionException #202
- Reduced logging level for these. They're unexpected, but not problematic.
- fixes hilt conflict oss plugin so cannot build project. #209 fixes Issue with enableAggregatingTask flag / AGP 7.0 / oss-licenses dagger#2744 fixes After upgrading to Gradle 7, getDependencies fails #194
- Also requires updating to hilt 2.40.5 (perhaps lower) to work with AGP 7.1+.
|
@jkasnicki @caller9 Any timeline when this version |
Collaborator
Author
|
@rpadma The goal is to ship it next week. |
jdochez
reviewed
Feb 23, 2022
jdochez
left a comment
Collaborator
There was a problem hiding this comment.
I did not look much into the Configuration handling as I felt it was mostly unchanged ?
…y and licenses task.
jkasnicki
approved these changes
Feb 23, 2022
This was referenced Dec 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.