Timing could lead to unresponsive bot #5

Activity

1. mattdavis0351 commented on Jan 22, 2020

   

   mattdavis0351

   on Jan 22, 2020

   Contributor

   More actions

   maybe we abandon verifying things with check_suite.completed. In cases like this we may be able to use the pull request name from within the check_suite event. Take a look at the object below, you'll see the PR name.

   "check_suite": {
       "id": 118578147,
       "node_id": "MDEwOkNoZWNrU3VpdGUxMTg1NzgxNDc=",
       "head_branch": "changes",
       "head_sha": "ec26c3e57ca3a959ca5aad62de7213c562f8c821",
       "status": "completed",
       "conclusion": "success",
       "url": "https://api.github.com/repos/Codertocat/Hello-World/check-suites/118578147",
       "before": "6113728f27ae82c7b1a177c8d03f9e96e0adf246",
       "after": "ec26c3e57ca3a959ca5aad62de7213c562f8c821",
       "pull_requests": [
         {
           "url": "https://api.github.com/repos/Codertocat/Hello-World/pulls/2",
           "id": 279147437,
           "number": 2,
           "head": {
             "ref": "changes",
             "sha": "ec26c3e57ca3a959ca5aad62de7213c562f8c821",
             "repo": {
               "id": 186853002,
               "url": "https://api.github.com/repos/Codertocat/Hello-World",
               "name": "Hello-World"
             }

   Drilling down deep enough to get the name may pose a challenge for what we can do with Learning Lab though.
2. hectorsector

   added

   bugSomething isn't workingSomething isn't working

   on Jan 28, 2020