Consider validating against PR titles instead of numbers

When validating a learner's action, leaving everything up to the pull request number puts the learner in a state that they are unable to recover from. For example, after the learner merges say PR 2, and let's assume Learning Lab misses that event (it did in my testing), the learner is then unable to move forward because they are told to merge PR 2. Instead, we can capture the title, and tell the learner that all the need to do is merge a PR with that title.

write-github-script/config.yml

Lines 123 to 134 in 3396a67

    
           - type: gate 
        
             every: true 
        
             gates: 
        
               - left: '{{ payload.pull_request.number }}' 
        
                 operator: === 
        
                 right: '{{ store.firstPullNumber }}' 
        
               - left: '{{ payload.pull_request.merged }}' 
        
             else: 
        
               - type: respond 
        
                 with: e-generic.md 
        
                 data: 
        
                   expected: merge pull request '{{ store.firstPullNumber }}'

@hectorsector

@hectorsector you ran into this issue even with the store implemented?

Yes! This is an issue with too strict of a validation on the PR number. The example I described above happened to me.

I guess our options are:

do not validate against the PR number on a merge event
maybe look for the right files in master instead?
validate on the title instead (using whatever title the learner chose)

Navigation Menu

Repository navigation

Consider validating against PR titles instead of numbers #7

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	- type: gate
	every: true
	gates:
	- left: '{{ payload.pull_request.number }}'
	operator: ===
	right: '{{ store.firstPullNumber }}'
	- left: '{{ payload.pull_request.merged }}'
	else:
	- type: respond
	with: e-generic.md
	data:
	expected: merge pull request '{{ store.firstPullNumber }}'

Consider validating against PR titles instead of numbers #7

Description

Activity

mattdavis0351 commented on Apr 18, 2020

hectorsector commented on Apr 22, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions