Preserve compact log event timestamps and report untimed evidence by pelikhan · Pull Request #74785 · github/gh-aw

pelikhan · 2026-11-04T07:12:31Z

Compact session logs previously exposed only export observation time, limiting event-time analysis and obscuring timestamp coverage. This change exports valid source clocks as standard OTLP timeUnixNano while keeping observedTimeUnixNano independent.

Changes

Preserve exact ISO nanosecond fractions and retain finite source-normalized provenance.timestampMs in the compact allowlist for numeric clocks.
Leave missing, invalid, negative, or uint64-overflow event times unset instead of substituting export time or ordering anchors.
Report gh-aw.session.untimed_events after transport-budget admission, preserving privacy masks, trace/span correlation, and existing loss accounting.
Document request-level quality attributes and query limitations: repeated resource counts are not additive per row, and unscanned activity remains unknown.

Validation

npm --prefix actions/setup/js run test:js -- --no-file-parallelism send_otlp_session_logs.test.cjs compact_unified_session.test.cjs otlp_protobuf.test.cjs unified_session_order.test.cjs - 186 tests passed, including local JSON/protobuf delivery, uint64 boundaries, source-clock precision, masking, and mixed timed/untimed budget admission.
make fmt-cjs && make lint-cjs
npm --prefix actions/setup/js run typecheck
make agent-report-progress - build, lint, and 108 impacted JavaScript tests passed.

No raw-session expansion, provider query pack, deployment, or workflow dispatch.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-11-04T07:13:58Z

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

github-actions · 2026-11-04T07:14:05Z

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · routed: gpt56 max · ~1 AIC · ⌖ ~1 AIC · ⊞ 6.3K · ◷

🧪 Test quality analysis by Test Quality Sentinel

github-actions · 2026-11-04T07:14:14Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

github-actions · 2026-11-04T07:14:17Z

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · routed: gpt56 max · ~4 AIC · ⌖ ~1 AIC · ⊞ 118 · ◷

Generated by Ponytail Reviewer for #74785

github-actions · 2026-11-04T07:14:35Z

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · routed: gpt56 max · ~1 AIC · ⌖ ~2 AIC · ⊞ 7.7K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

github-actions · 2026-11-04T07:20:19Z

Comment Memory

Peek at saved memory (pr-code-quality-reviewer)

reviewed_at: 2026-11-04T07:15:53Z
review_event: COMMENT
top_themes: [invalid normalized timestamp fallback]
files_reviewed: [actions/setup/js/compact_unified_session.cjs, actions/setup/js/send_otlp_session_logs.cjs, actions/setup/js/unified_session_order.cjs, docs/src/content/docs/reference/compiler-enterprise-environment-controls.md, docs/src/content/docs/specs/unified-agent-session-specification.md]
comment_count: 1

Note

This comment is managed by comment memory.

Expand the saved memory block to view or edit the persistent context for this thread.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~3 AIC · ⌖ ~1 AIC · ⊞ 1.6K · ◷
_{Comment /review to run again}

github-actions

Review found one correctness issue in event-time handling: an invalid normalized clock can fall back to a different native numeric timestamp and misrepresent timeUnixNano. Please see the inline comment; otherwise the timestamp projection, privacy handling, and coverage look consistent with the stated design.

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~3 AIC · ⌖ ~1 AIC · ⊞ 1.6K
_{Comment /review to run again}

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

pelikhan · 2026-11-04T07:23:00Z

Regarding the review status update: no code change is needed for the notification itself. The resulting invalid-clock finding was accepted and fixed in 0d3975a.

pelikhan · 2026-11-04T07:23:01Z

Regarding the test analysis result: acknowledged as informational, not proof of validation or publication. No specific change was requested; the clock regression and final repository validation passed independently before pushing 0d3975a.

pelikhan · 2026-11-04T07:23:02Z

Regarding the skills review status: no change is needed because the notification contains no actionable finding.

pelikhan · 2026-11-04T07:23:03Z

Regarding the Ponytail review status: no change is needed because this start notification does not request a code change.

pelikhan · 2026-11-04T07:23:04Z

Regarding the design gate result: no design change is requested by the reported_no_action outcome. This status is informational and is not being treated as proof of full completion.

pelikhan · 2026-11-04T07:23:05Z

Regarding the managed review memory: the recorded invalid-clock finding was accepted and fixed in 0d3975a. No additional change or edit to managed memory is needed because this comment adds no independent request.

Copilot

🟡 Changes recommended

Retained numeric timestamp provenance bypasses redaction, allowing masked source times to be recovered from exported data.

3 open issues

What changed in this PR

This PR adds source event timestamps to compact unified-session OTLP logs, separating event time from export observation time and exposing timestamp coverage.

Changes:

Retains normalized numeric clocks and exports source timestamps with nanosecond precision.
Counts untimed records after transport-budget admission.
Adds timestamp, masking, and budget tests, plus guidance for interpreting export-quality attributes.

File	Description
`docs/src/content/docs/specs/unified-agent-session-specification.md`	Defines clock preservation and untimed-record requirements.
`docs/src/content/docs/reference/compiler-enterprise-environment-controls.md`	Documents timestamps, quality attributes, and query limitations.
`actions/setup/js/send_otlp_session_logs.test.cjs`	Adds timestamp, masking, budget, and delivery coverage.
`actions/setup/js/send_otlp_session_logs.cjs`	Exports event times and counts admitted untimed records.
`actions/setup/js/compact_unified_session.test.cjs`	Tests finite normalized-clock projection.
`actions/setup/js/compact_unified_session.cjs`	Allows finite `provenance.timestampMs` in compact events.

_{Review effort: Balanced (auto)}

Copilot · 2026-11-04T15:30:08Z

  const projected = { type: event.type, data, ...projectScalars(event, ["timestamp"]) };
  if (isRecord(event.provenance)) {
    const provenance = projectScalars(event.provenance, ["component", "phase", "path", "index"]);
+    if (typeof event.provenance.timestampMs === "number" && Number.isFinite(event.provenance.timestampMs)) provenance.timestampMs = event.provenance.timestampMs;


Fixed in f21e905: session serialization now removes derived provenance.timestampMs whenever its source timestamp is redacted by publication or exporter masks. Regression coverage verifies both masking paths.

Copilot · 2026-11-04T15:30:08Z

+ * @returns {string | undefined}
+ */
+function eventTimeUnixNano(event) {
+  const isoTime = typeof event.timestamp === "string" ? sessionTimestampNs(event) : undefined;


Fixed in f21e905: the shared timestamp parser validates calendar and time components before parsing, and invalid timestamp strings no longer fall back to normalized provenance. Added an impossible-date regression.

Copilot · 2026-11-04T15:30:08Z

+function eventTimeUnixNano(event) {
+  const isoTime = typeof event.timestamp === "string" ? sessionTimestampNs(event) : undefined;
+  const normalizedTime = typeof event.provenance?.timestampMs === "number" ? sessionTimestampNs({ timestamp: event.provenance.timestampMs }) : undefined;
+  const time = isoTime ?? normalizedTime ?? sessionTimestampNs(event);


Fixed in f21e905: a supplied but invalid normalized clock stays untimed, and native numeric fallback is now limited to events without provenance. Regression coverage includes out-of-range normalized values.

github-actions

Skills-Based Review 🧠

Applied /diagnosing-bugs and /tdd to the timestamp export path. Requesting changes: one spec-violating fallback and one precision loss, plus a test that misses both.

📋 Key Themes & Highlights

Key Themes

Fallback reinterprets out-of-range clocks: eventTimeUnixNano falls through to the native timestamp when provenance.timestampMs is finite but out of range. This breaks the spec rule (spec line 627) that out-of-range times MUST stay unset.
Nanosecond precision loss: OTel timestamp values are converted to a double timestampMs, so 1792522800123456789 exports as ...787.
Weak test coverage: the out-of-range test at send_otlp_session_logs.test.cjs line 91 uses -1 and 8640000000000000, which the uint64 range check already rejects. It never reaches the buggy path.
Calendar validation gap (outside this diff): sessionTimestampNs in unified_session_order.cjs accepts impossible dates. 2026-02-30T00:00:00Z rolls over to March 2 because Date.parse normalizes it. Validate the calendar date before parsing. Not covered by an inline comment because the file is not in the diff.

Positive Highlights

✅ Keeping observedTimeUnixNano separate from timeUnixNano is the right design.
✅ The gh-aw.session.untimed_events attribute makes missing clocks visible.
✅ The new tests cover ISO fractions, timezone offsets, and the uint64 bounds.

Verification

I probed the current code and the suggested fix in Node. The fix matched 15 inputs with 0 mismatches. I did not run the vitest suite, because vitest is not installed in this checkout.

@copilot please address the review comments above.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · routed: haiku55 xhigh · ~9 AIC · ⌖ ~1 AIC · ⊞ 5.4K
_{Comment /matt to run again}

github-actions · 2026-11-04T07:28:32Z

+ */
+function eventTimeUnixNano(event) {
+  const isoTime = typeof event.timestamp === "string" ? sessionTimestampNs(event) : undefined;
+  const normalizedTime = typeof event.provenance?.timestampMs === "number" ? sessionTimestampNs({ timestamp: event.provenance.timestampMs }) : undefined;


[/diagnosing-bugs] OTel nanosecond clocks lose precision here. unified_session.cjs converts the ns string to a double timestampMs (for example 1792522800123.4568), and this line then rebuilds ns from that double. 1792522800123456789 exports as 1792522800123456787. The body keeps the exact value, but timeUnixNano is wrong. The exactNs line in the suggestion on line 38 fixes this by parsing the original digit string.

@copilot please address this.

Fixed in f21e905: digit-string source clocks are parsed as nanoseconds when normalized provenance is present, preserving all digits. Added a sub-millisecond precision regression.

github-actions · 2026-11-04T07:28:32Z

+    }
+  );
+
+  it.each([-1, 8640000000000000])("does not reinterpret an out-of-range normalized clock %j in native timestamp units", async timestampMs => {


[/tdd] This test never reaches the fallback. -1 and 8640000000000000 are rejected by the >= 0n and uint64 range checks, so the test passes even with the bug in the comment on line 38. Add the values that expose it, plus a nanosecond digit-string case with sub-millisecond digits so the precision fix stays covered.

💡 Suggested test cases

it.each([-1, 8640000000000000, 8640000000000001, 1e300])("does not reinterpret an out-of-range normalized clock %j in native timestamp units", async timestampMs => {

Also add a case with timestamp: "1792522800123456789" and provenance: { timestampMs: 1792522800123.4568 }, expecting timeUnixNano: "1792522800123456789". The existing sub-millisecond case uses an ISO string, so it skips the precision path.

@copilot please address this.

Updated in f21e905: the out-of-range cases now include 8640000000000001 and 1e300, and a digit-string nanosecond case verifies exact precision.

github-actions · 2026-11-04T07:28:32Z

+function eventTimeUnixNano(event) {
+  const isoTime = typeof event.timestamp === "string" ? sessionTimestampNs(event) : undefined;
+  const normalizedTime = typeof event.provenance?.timestampMs === "number" ? sessionTimestampNs({ timestamp: event.provenance.timestampMs }) : undefined;
+  const time = isoTime ?? normalizedTime ?? sessionTimestampNs(event);


[/diagnosing-bugs] An out-of-range normalized clock falls through to the native timestamp, so the event gets a wrong time instead of none. Example: {timestamp: 1700000000, provenance: {timestampMs: 1e300}} exports 1700000000000000 ns. The spec at line 627 says out-of-range times MUST stay unset, so this violates it. The same path reads an out-of-range seconds clock from audit.jsonl (timestamp: 1e13) as milliseconds, giving year 2286.

💡 Suggested fix

Only fall back to the native clock when provenance is absent, and parse digit strings with the nanosecond unit:

const exactNs = typeof event.provenance?.timestampMs === "number" && typeof event.timestamp === "string" ? sessionTimestampNs(event, "nanoseconds") : undefined; const time = isoTime ?? exactNs ?? (event.provenance === undefined ? sessionTimestampNs(event) : normalizedTime);

I checked this against 15 probe inputs, including the existing fixtures, with 0 mismatches.

@copilot please address this.

Fixed in f21e905: invalid normalized clocks cannot fall back to native timestamps, and events with provenance but no valid normalized clock remain untimed. Added coverage for an invalid seconds-based audit.jsonl clock.

github-actions · 2026-11-04T07:55:30Z

Note

The pull request was not created — a fallback review issue was created instead due to protected file changes: #74796

PR Finisher

Submitted for publication (not confirmed pushed): merge of main; masked source timestamps now also drop derived provenance.timestampMs (publication and exporter masks); impossible ISO calendar dates are rejected; a supplied normalized clock never falls back to the native timestamp; exact ns digit strings keep full precision; regressions added.

Validation: vitest and Prettier could not be installed (npm registry cert failure), so make agent-report-progress was not run. I checked the logic with standalone Node scripts instead. CI needs a maintainer re-trigger. Review replies/resolutions are deferred until the fix is published.

Sous-chef head: 0d3975a
Sous-chef work: 36f680bdfa6524de218f6ba2ac6c2d0ea6f53cf52a580afd5128307187a99ceb 61110139dc3bcc66567cc612b195b778b7a5df2a56b0d482f768d7558cae073f 622cc74f57102a9b425a0b36e418a26c49e702fcbcb413edc7fe4c0b70538f61 88845676b8b6d7a90d19cdcc2944e9ce4a8b709b10f9b7bab12909b47cc8c0f5 abb5b8846da5863d6830acc23e9cf9633b7a9736e10ca1f5162d1b87502153c0 f07fe74be3dcb876d553e708591351855dbe50cb944beaf00171cfe4e46e4be5
Sous-chef state: 8f8c60fa4395f9008f881beda7a8e95cf576dd228b896e948d302f3424affea8

Generated by 🏁 PR Finisher · copilot · auto · ~44 AIC · ⌖ ~2 AIC · ⊞ 10.7K · ◷

github-actions · 2026-11-04T08:37:03Z

Note

The pull request was not created — a fallback review issue was created instead due to protected file changes: #74803

PR finisher

Submitted for publication (not yet confirmed pushed): merge of main plus fixes for all listed review items: calendar validation of ISO clocks, no native-unit fallback when the normalized clock is invalid/out-of-range, exact ns precision from digit strings, and dropping derived timestampMs when its source timestamp is masked (publication and exporter). Regression tests were added/extended.

Validation: vitest could not run (npm registry certificate error blocked install); only a Node sanity check and prettier were run. make agent-report-progress was not run. CI needs a maintainer re-trigger.

Review thread replies/resolutions are deferred until the fix is published.

PR finisher dispatch requested for the following outstanding work: see review threads 4464792186, 4464792234, 4464792263, 4464828987, 4464828994, 4464829000.

Sous-chef head: 0d3975a
Sous-chef work: 36f680bdfa6524de218f6ba2ac6c2d0ea6f53cf52a580afd5128307187a99ceb 61110139dc3bcc66567cc612b195b778b7a5df2a56b0d482f768d7558cae073f 622cc74f57102a9b425a0b36e418a26c49e702fcbcb413edc7fe4c0b70538f61 88845676b8b6d7a90d19cdcc2944e9ce4a8b709b10f9b7bab12909b47cc8c0f5 abb5b8846da5863d6830acc23e9cf9633b7a9736e10ca1f5162d1b87502153c0 f07fe74be3dcb876d553e708591351855dbe50cb944beaf00171cfe4e46e4be5
Sous-chef state: 8f8c60fa4395f9008f881beda7a8e95cf576dd228b896e948d302f3424affea8

Generated by 🏁 PR Finisher · copilot · auto · ~38 AIC · ⌖ ~2 AIC · ⊞ 10.7K · ◷

github-actions · 2026-11-04T09:06:03Z

Note

The pull request was not created — a fallback review issue was created instead due to protected file changes: #74812

PR Finisher

Submitted for publication (staged, not confirmed pushed): merge of main plus fixes for the 6 listed review items. Masked source timestamps now drop derived provenance.timestampMs; impossible calendar dates stay untimed; exact ns digit strings are preserved; invalid or out-of-range normalized clocks no longer fall back to native units. Regression tests were added.

Validation: vitest could not be installed (registry certificate error), so tests were not run. Only manual node checks of the changed logic passed, and make agent-report-progress was not run. CI needs a maintainer re-trigger.

Review thread replies/resolutions are deferred until the fix is published.

Sous-chef head: 0d3975a
Sous-chef work: 36f680bdfa6524de218f6ba2ac6c2d0ea6f53cf52a580afd5128307187a99ceb 61110139dc3bcc66567cc612b195b778b7a5df2a56b0d482f768d7558cae073f 622cc74f57102a9b425a0b36e418a26c49e702fcbcb413edc7fe4c0b70538f61 88845676b8b6d7a90d19cdcc2944e9ce4a8b709b10f9b7bab12909b47cc8c0f5 abb5b8846da5863d6830acc23e9cf9633b7a9736e10ca1f5162d1b87502153c0 f07fe74be3dcb876d553e708591351855dbe50cb944beaf00171cfe4e46e4be5
Sous-chef state: 8f8c60fa4395f9008f881beda7a8e95cf576dd228b896e948d302f3424affea8

Generated by 🏁 PR Finisher · copilot · auto · ~36 AIC · ⌖ ~2 AIC · ⊞ 10.7K · ◷

github-actions · 2026-11-04T09:32:54Z

Note

The pull request was not created — a fallback review issue was created instead due to protected file changes: #74819

PR finisher

Submitted for publication (not confirmed pushed): merged main and fixed the review items — derived timestampMs is dropped when its source clock is masked; impossible calendar dates stay untimed; native timestamp is no longer used when a normalized clock is present but invalid/out of range; ns digit strings keep exact precision; tests extended.

Validation: syntax checks and a manual calendar check only. Vitest could not be installed (npm registry certificate error), so the test suite and make agent-report-progress were not run.

Hand-off: review replies/resolutions are deferred until the push is published. A maintainer needs to run CI.

Sous-chef head: 0d3975a
Sous-chef work: 36f680bdfa6524de218f6ba2ac6c2d0ea6f53cf52a580afd5128307187a99ceb 61110139dc3bcc66567cc612b195b778b7a5df2a56b0d482f768d7558cae073f 622cc74f57102a9b425a0b36e418a26c49e702fcbcb413edc7fe4c0b70538f61 88845676b8b6d7a90d19cdcc2944e9ce4a8b709b10f9b7bab12909b47cc8c0f5 abb5b8846da5863d6830acc23e9cf9633b7a9736e10ca1f5162d1b87502153c0 f07fe74be3dcb876d553e708591351855dbe50cb944beaf00171cfe4e46e4be5
Sous-chef state: 8f8c60fa4395f9008f881beda7a8e95cf576dd228b896e948d302f3424affea8

Generated by 🏁 PR Finisher · copilot · auto · ~29 AIC · ⌖ ~2 AIC · ⊞ 10.7K · ◷

github-actions · 2026-11-04T10:40:27Z

Note

The pull request was not created — a fallback review issue was created instead due to protected file changes: #74828

PR finisher

Submitted for publication (not yet confirmed pushed): merged origin/main and addressed the 6 review items (calendar validation, no native fallback when a normalized clock is invalid or out of range, exact ns digit-string precision, masked source clock now drops derived timestampMs) with new regression tests.

Validation: only node --check and manual node probes ran. npm ci failed (registry certificate error), so vitest, prettier and make agent-report-progress did not run.

Remaining: review replies and resolutions are deferred until the fix is published. A maintainer needs to re-trigger CI and run the JS tests and make fmt-cjs.

Sous-chef head: 0d3975a
Sous-chef work: 36f680bdfa6524de218f6ba2ac6c2d0ea6f53cf52a580afd5128307187a99ceb 61110139dc3bcc66567cc612b195b778b7a5df2a56b0d482f768d7558cae073f 622cc74f57102a9b425a0b36e418a26c49e702fcbcb413edc7fe4c0b70538f61 88845676b8b6d7a90d19cdcc2944e9ce4a8b709b10f9b7bab12909b47cc8c0f5 abb5b8846da5863d6830acc23e9cf9633b7a9736e10ca1f5162d1b87502153c0 f07fe74be3dcb876d553e708591351855dbe50cb944beaf00171cfe4e46e4be5
Sous-chef state: 8f8c60fa4395f9008f881beda7a8e95cf576dd228b896e948d302f3424affea8

Generated by 🏁 PR Finisher · copilot · auto · ~37 AIC · ⌖ ~2 AIC · ⊞ 10.7K · ◷

github-actions · 2026-11-04T11:53:56Z

Note

The pull request was not created — a fallback review issue was created instead due to protected file changes: #74840

PR finisher

Submitted for publication (staged, not confirmed): merged main, and fixed the clock review items. Masked source clocks now drop derived provenance.timestampMs. Impossible calendar dates stay untimed. Out-of-range or invalid normalized clocks no longer fall back to the native timestamp. Nanosecond digit strings now export exactly. Regression tests were added or extended.

Validation: prettier and a manual node check only. Vitest could not be installed because the npm registry certificate was rejected, so the test suite and make agent-report-progress were not run. Review replies and resolutions are deferred until the fix is published. Maintainer must re-trigger CI.

PR finisher dispatch requested for the following outstanding work: see Sous-chef lines below.

Sous-chef head: 0d3975a
Sous-chef work: 36f680bdfa6524de218f6ba2ac6c2d0ea6f53cf52a580afd5128307187a99ceb 61110139dc3bcc66567cc612b195b778b7a5df2a56b0d482f768d7558cae073f 622cc74f57102a9b425a0b36e418a26c49e702fcbcb413edc7fe4c0b70538f61 88845676b8b6d7a90d19cdcc2944e9ce4a8b709b10f9b7bab12909b47cc8c0f5 abb5b8846da5863d6830acc23e9cf9633b7a9736e10ca1f5162d1b87502153c0 f07fe74be3dcb876d553e708591351855dbe50cb944beaf00171cfe4e46e4be5
Sous-chef state: 8f8c60fa4395f9008f881beda7a8e95cf576dd228b896e948d302f3424affea8

Generated by 🏁 PR Finisher · copilot · auto · ~37 AIC · ⌖ ~2 AIC · ⊞ 10.7K · ◷

github-actions · 2026-11-04T12:32:05Z

Note

The pull request was not created — a fallback review issue was created instead due to protected file changes: #74847

PR finisher

Submitted for publication (staged, not confirmed): merged main; masked source timestamps now drop derived provenance.timestampMs (publication + exporter); impossible calendar dates are rejected; OTLP time no longer falls back to native units when the normalized clock is invalid/out of range, and ns digit strings keep exact precision. Added regression tests.

Validation: node smoke checks and prettier passed. Vitest could not run locally (npm registry cert failure), so tests are unrun. Review threads are left open pending publication; CI needs a maintainer re-trigger.

PR finisher dispatch requested for the following outstanding work: items 1-7 (merge main, review threads on clock masking, calendar validation, OTLP fallback/precision/tests).

Sous-chef head: 0d3975a
Sous-chef work: 36f680bdfa6524de218f6ba2ac6c2d0ea6f53cf52a580afd5128307187a99ceb 61110139dc3bcc66567cc612b195b778b7a5df2a56b0d482f768d7558cae073f 622cc74f57102a9b425a0b36e418a26c49e702fcbcb413edc7fe4c0b70538f61 88845676b8b6d7a90d19cdcc2944e9ce4a8b709b10f9b7bab12909b47cc8c0f5 abb5b8846da5863d6830acc23e9cf9633b7a9736e10ca1f5162d1b87502153c0 f07fe74be3dcb876d553e708591351855dbe50cb944beaf00171cfe4e46e4be5
Sous-chef state: 8f8c60fa4395f9008f881beda7a8e95cf576dd228b896e948d302f3424affea8

Generated by 🏁 PR Finisher · copilot · auto · ~38 AIC · ⌖ ~2 AIC · ⊞ 10.7K · ◷

github-actions · 2026-11-04T13:08:18Z

Note

The pull request was not created — a fallback review issue was created instead due to protected file changes: #74856

PR Finisher

Submitted for publication (staged, not confirmed pushed): merged main, and fixed the review items: derived timestampMs is dropped when its source clock is masked; invalid calendar dates stay untimed; invalid normalized clocks no longer fall back to native units; exact ns digit strings keep precision. Added regression tests.

Validation: node sanity checks only. vitest could not be installed (npm cert error), and make agent-report-progress was not run. Review replies/resolutions are deferred until the push is published. A maintainer must re-trigger CI.

Sous-chef head: 0d3975a
Sous-chef work: 36f680bdfa6524de218f6ba2ac6c2d0ea6f53cf52a580afd5128307187a99ceb 61110139dc3bcc66567cc612b195b778b7a5df2a56b0d482f768d7558cae073f 622cc74f57102a9b425a0b36e418a26c49e702fcbcb413edc7fe4c0b70538f61 88845676b8b6d7a90d19cdcc2944e9ce4a8b709b10f9b7bab12909b47cc8c0f5 abb5b8846da5863d6830acc23e9cf9633b7a9736e10ca1f5162d1b87502153c0 f07fe74be3dcb876d553e708591351855dbe50cb944beaf00171cfe4e46e4be5
Sous-chef state: 8f8c60fa4395f9008f881beda7a8e95cf576dd228b896e948d302f3424affea8

Generated by 🏁 PR Finisher · copilot · auto · ~32 AIC · ⌖ ~2 AIC · ⊞ 10.7K · ◷

github-actions · 2026-11-04T13:41:06Z

Note

The pull request was not created — a fallback review issue was created instead due to protected file changes: #74862

PR finisher

Submitted for publication (staged, not confirmed): merged main; rejected impossible calendar dates; exporter keeps exact ns digit strings; no native-unit fallback when the normalized clock is invalid or out of range; derived timestampMs is dropped when its source clock is masked (publication and exporter). Added regression tests.

Validation: only a quick Node sanity check of the clock logic. npm ci failed with a certificate error, so vitest, make agent-report-progress and lint were not run. Review threads are not replied to or resolved yet, pending publication. A maintainer needs to re-trigger CI.

Sous-chef head: 0d3975a Sous-chef work: 36f680bdfa6524de218f6ba2ac6c2d0ea6f53cf52a580afd5128307187a99ceb 61110139dc3bcc66567cc612b195b778b7a5df2a56b0d482f768d7558cae073f 622cc74f57102a9b425a0b36e418a26c49e702fcbcb413edc7fe4c0b70538f61 88845676b8b6d7a90d19cdcc2944e9ce4a8b709b10f9b7bab12909b47cc8c0f5 abb5b8846da5863d6830acc23e9cf9633b7a9736e10ca1f5162d1b87502153c0 f07fe74be3dcb876d553e708591351855dbe50cb944beaf00171cfe4e46e4be5 Sous-chef state: 8f8c60fa4395f9008f881beda7a8e95cf576dd228b896e948d302f3424affea8

Generated by 🏁 PR Finisher · copilot · auto · ~37 AIC · ⌖ ~2 AIC · ⊞ 10.7K · ◷

github-actions · 2026-11-04T14:13:05Z

Note

The pull request was not created — a fallback review issue was created instead due to protected file changes: #74867

PR finisher

Submitted for publication (not confirmed pushed): merged main and fixed the review items — derived provenance.timestampMs is dropped when its source timestamp is masked; impossible ISO calendar dates stay untimed; invalid/out-of-range normalized clocks no longer fall back to the native timestamp; ns digit strings keep exact precision. Added regression cases.

Validation: could not run vitest/make agent-report-progress (npm registry certificate failure); only node smoke checks were run. Please re-trigger CI.

Review thread replies/resolutions are deferred until the fix is published.

Sous-chef head: 0d3975a
Sous-chef work: 36f680bdfa6524de218f6ba2ac6c2d0ea6f53cf52a580afd5128307187a99ceb 61110139dc3bcc66567cc612b195b778b7a5df2a56b0d482f768d7558cae073f 622cc74f57102a9b425a0b36e418a26c49e702fcbcb413edc7fe4c0b70538f61 88845676b8b6d7a90d19cdcc2944e9ce4a8b709b10f9b7bab12909b47cc8c0f5 abb5b8846da5863d6830acc23e9cf9633b7a9736e10ca1f5162d1b87502153c0 f07fe74be3dcb876d553e708591351855dbe50cb944beaf00171cfe4e46e4be5
Sous-chef state: 8f8c60fa4395f9008f881beda7a8e95cf576dd228b896e948d302f3424affea8

Generated by 🏁 PR Finisher · copilot · auto · ~35 AIC · ⌖ ~2 AIC · ⊞ 10.7K · ◷

github-actions · 2026-11-04T14:42:32Z

Note

The pull request was not created — a fallback review issue was created instead due to protected file changes: #74873

PR Finisher

Submitted for publication (staged, not confirmed pushed): merged main, plus fixes for the listed review items:

Masked source clocks now also drop the derived provenance.timestampMs (publication and exporter masks).
Impossible calendar dates (e.g. 2026-02-29) are rejected, so the event stays untimed.
OTLP no longer falls back to the native timestamp when the normalized clock is invalid or out of range.
Nanosecond digit strings are exported exactly, not rebuilt from a double.
Tests added for the above.

Validation: Prettier and node --check pass, and I ran a manual smoke check. Vitest could not run because npm ci fails against the unreachable registry (self-signed cert). make agent-report-progress was not run for the same reason.

Review thread replies/resolutions are deferred until the fix is published. CI needs a maintainer re-trigger after publication.

PR finisher dispatch requested for the following outstanding work (items 1–7 above).

Sous-chef head: 0d3975a
Sous-chef work: 36f680bdfa6524de218f6ba2ac6c2d0ea6f53cf52a580afd5128307187a99ceb 61110139dc3bcc66567cc612b195b778b7a5df2a56b0d482f768d7558cae073f 622cc74f57102a9b425a0b36e418a26c49e702fcbcb413edc7fe4c0b70538f61 88845676b8b6d7a90d19cdcc2944e9ce4a8b709b10f9b7bab12909b47cc8c0f5 abb5b8846da5863d6830acc23e9cf9633b7a9736e10ca1f5162d1b87502153c0 f07fe74be3dcb876d553e708591351855dbe50cb944beaf00171cfe4e46e4be5
Sous-chef state: 8f8c60fa4395f9008f881beda7a8e95cf576dd228b896e948d302f3424affea8

Generated by 🏁 PR Finisher · copilot · auto · ~36 AIC · ⌖ ~2 AIC · ⊞ 10.7K · ◷

Ok

pelikhan · 2026-11-04T15:07:27Z

@copilot run pr-finisher skill

github-actions · 2026-11-04T15:10:55Z

Note

The pull request was not created — a fallback review issue was created instead due to protected file changes: #74879

PR finisher summary (submitted for publication, not confirmed pushed):

Merged main locally.
Masked source clocks now drop derived provenance.timestampMs (publication and exporter masks).
Invalid calendar dates (e.g. 2026-02-29) are left untimed.
Native timestamp is no longer reused when a numeric normalized clock is invalid; ns digit strings export exactly.
Added regression tests for these cases.

Validation: vitest could not be installed (npm registry self-signed cert), so the test suite and make agent-report-progress were NOT run; only a manual node check of calendar and masking behavior passed. CI is stale after push and needs a maintainer re-trigger. Review replies/resolutions are deferred until the fix is published.

Sous-chef head: 0d3975a
Sous-chef work: 36f680bdfa6524de218f6ba2ac6c2d0ea6f53cf52a580afd5128307187a99ceb 61110139dc3bcc66567cc612b195b778b7a5df2a56b0d482f768d7558cae073f 622cc74f57102a9b425a0b36e418a26c49e702fcbcb413edc7fe4c0b70538f61 88845676b8b6d7a90d19cdcc2944e9ce4a8b709b10f9b7bab12909b47cc8c0f5 abb5b8846da5863d6830acc23e9cf9633b7a9736e10ca1f5162d1b87502153c0 f07fe74be3dcb876d553e708591351855dbe50cb944beaf00171cfe4e46e4be5
Sous-chef state: 8f8c60fa4395f9008f881beda7a8e95cf576dd228b896e948d302f3424affea8

Generated by 🏁 PR Finisher · copilot · auto · ~35 AIC · ⌖ ~2 AIC · ⊞ 10.7K · ◷

pelikhan · 2026-11-04T15:25:22Z

@copilot run pr-finisher skill

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-11-04T23:53:23Z

🎉 This pull request is included in a new release.

Release: v1.2.0

Preserve compact session log clocks and report untimed evidence

0c46b32

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

pelikhan marked this pull request as ready for review November 4, 2026 07:12

Copilot AI auto review requested due to automatic review settings November 4, 2026 07:12

Copilot started reviewing on behalf of pelikhan November 4, 2026 07:18

View session

github-actions Bot reviewed Nov 4, 2026

View reviewed changes

Comment thread actions/setup/js/send_otlp_session_logs.cjs Resolved

Reject invalid normalized log clocks without native fallback

0d3975a

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI reviewed Nov 4, 2026

View reviewed changes

github-actions Bot previously requested changes Nov 4, 2026

View reviewed changes

github-actions Bot mentioned this pull request Nov 4, 2026

[pr-sous-chef] PR Sous Chef: Nudged 2 PRs toward finisher review #74673

Closed

github-actions Bot mentioned this pull request Nov 4, 2026

[gh-aw] Protected Files: Preserve compact log event timestamps and report untimed evidence #74796

Open

github-actions Bot mentioned this pull request Nov 4, 2026

[gh-aw] Protected Files: Preserve compact log event timestamps and report untimed evidence #74803

Open

This was referenced Nov 4, 2026

[gh-aw] Protected Files: Preserve compact log event timestamps and report untimed evidence #74812

Open

[gh-aw] Protected Files: Preserve compact log event timestamps and report untimed evidence #74819

Open

This was referenced Nov 4, 2026

[gh-aw] Protected Files: Preserve compact log event timestamps and report untimed evidence #74831

Open

[agentic-token-audit] AIC usage audit 2026-11-04 #74838

Open

This was referenced Nov 4, 2026

[gh-aw] Protected Files: Preserve compact log event timestamps and report untimed evidence #74840

Open

[gh-aw] Protected Files: Preserve compact log event timestamps and report untimed evidence #74847

Open

github-actions Bot mentioned this pull request Nov 4, 2026

[gh-aw] Protected Files: Preserve compact log event timestamps and report untimed evidence #74856

Open

github-actions Bot mentioned this pull request Nov 4, 2026

[gh-aw] Protected Files: Preserve compact log event timestamps and report untimed evidence #74862

Open

This was referenced Nov 4, 2026

[gh-aw] Protected Files: Preserve compact log event timestamps and report untimed evidence #74867

Open

[blog] Agent of the Day – 2026-11-04 #74870

Merged

[gh-aw] Protected Files: Preserve compact log event timestamps and report untimed evidence #74873

Open

Copilot started work on behalf of pelikhan November 4, 2026 15:07

View session

github-actions Bot mentioned this pull request Nov 4, 2026

[gh-aw] Protected Files: Preserve compact log event timestamps and report untimed evidence #74879

Closed

Copilot AI mentioned this pull request Nov 4, 2026

Allow PR Finisher to update two shared AW files #74885

Merged

Copilot AI and others added 2 commits November 4, 2026 15:25

Protect masked clocks and reject invalid timestamps

ab78135

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Avoid native fallback for invalid source clocks

f21e905

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan November 4, 2026 15:31

Copilot started work on behalf of pelikhan November 4, 2026 15:31

View session

pelikhan merged commit b7a5015 into main Nov 4, 2026
73 of 74 checks passed

pelikhan deleted the pelikhan/compact-log-clocks branch November 4, 2026 15:32

Copilot stopped work on behalf of pelikhan due to an error November 4, 2026 15:33
The session was cancelled by the user.

Conversation

pelikhan commented Nov 4, 2026

Changes

Validation

Uh oh!

github-actions Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Quality Sentinel

Uh oh!

github-actions Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ponytail Reviewer

Uh oh!

github-actions Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Design Decision Gate 🏗️

Uh oh!

github-actions Bot commented Nov 4, 2026

Comment Memory

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pelikhan commented Nov 4, 2026

Uh oh!

pelikhan commented Nov 4, 2026

Uh oh!

pelikhan commented Nov 4, 2026

Uh oh!

pelikhan commented Nov 4, 2026

Uh oh!

pelikhan commented Nov 4, 2026

Uh oh!

pelikhan commented Nov 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Copilot AI Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Key Themes

Positive Highlights

Verification

Uh oh!

github-actions Bot Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Nov 4, 2026 •

edited

Loading

github-actions Bot commented Nov 4, 2026 •

edited

Loading

github-actions Bot commented Nov 4, 2026 •

edited

Loading

github-actions Bot commented Nov 4, 2026 •

edited

Loading

github-actions Bot commented Nov 4, 2026 •

edited

Loading