Repository navigation
Conversation
Record plain, escaped, raw, multiline, and interpolated literals so the string decoding required by regex parsing can be reviewed separately. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Exclude extractor-provided builtins so expected results do not depend on the extractor pack location. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Exercise full literal expressions, including currently missing multiline and escaped values, and retain an extractor corpus case distinguishing constants from interpolation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve multi-segment constants as literals while keeping interpolations separate. Decode escaped, raw, Unicode, and multiline strings so regex parsing receives runtime pattern text rather than source syntax. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle multi-line string literals and other variations.
Copilot made this change as part of some other work (porting the regex library), but I decided to split it out as a separate piece of work as it doesn't depend on any of that. The two changes seem reasonable to me, but I'm not familiar with these areas of code, especially the extractor part.
@asgerf I'd like to know what you think, should we be aiming to merge this, fix it, or is this the wrong direction entirely?