Skip to content

[inline-learn lib 3/3] Add direct MakeTest inline learning #23013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
d10c wants to merge 2 commits into from
Draft

[inline-learn lib 3/3] Add direct MakeTest inline learning #23013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0728c0a
Add direct MakeTest inline learning
d10c Nov 3, 2026
ae1a0d7
Reject unsafe direct inline expectation edits
d10c Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions java/ql/test/library-tests/InlineExpectationsTest/learn-edits/Test.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
| Test.java | 3 | append | 0 | 0 | // $ java-direct=safe |
| Test.java | 4 | replace | 25 | 37 | // $ foreign java-direct=safe |
8 changes: 8 additions & 0 deletions java/ql/test/library-tests/InlineExpectationsTest/learn-edits/Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
class Test {
void target() {} // $ java-direct
void safeAppend() {}
void safeReplace() {} // $ foreign
void unsafeHash() {}
void unsafeSpace() {} // $ foreign
void unsafeNewline() {} // $ foreign
}
37 changes: 37 additions & 0 deletions java/ql/test/library-tests/InlineExpectationsTest/learn-edits/Test.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
import java
import utils.test.InlineExpectationsTest

module DirectTest implements TestSig {
string getARelevantTag() { result = "java-direct" }

predicate tagIsIgnored(string expectedTag) { expectedTag = "foreign" }

predicate hasActualResult(Location location, string element, string tag, string value) {
exists(Method method |
method.getName() =
["target", "safeAppend", "safeReplace", "unsafeHash", "unsafeSpace", "unsafeNewline"] and
method.fromSource() and
location = method.getLocation() and
element = method.toString() and
tag = "java-direct" and
if method.getName() = "unsafeHash"
then value = "a#b"
else
if method.getName() = "unsafeSpace"
then value = "hello world"
else
if method.getName() = "unsafeNewline"
then value = "hello\nworld"
else
if method.getName() = ["safeAppend", "safeReplace"]
then value = "safe"
else value = ""
)
}
}

private module Test = MakeTest<DirectTest>;

from string file, int line, string operation, int startColumn, int endColumn, string text
where Test::learnEdits(file, line, operation, startColumn, endColumn, text)
select file, line, operation, startColumn, endColumn, text
4 changes: 4 additions & 0 deletions python/ql/lib/utils/test/internal/InlineExpectationsTestImpl.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,8 @@ module Impl implements InlineExpectationsTestSig {
relativePath.regexpMatch(".*\\.(py|pyi)") and
result = "#"
}

// Python source lines are not available here, so an explicit `\` continuation cannot be excluded.
bindingset[relativePath, line]
predicate canAppendCommentAtEndOfLine(string relativePath, int line) { none() }
}
Empty file added python/ql/test/library-tests/InlineExpectationsTest/learn-edits/Test.expected
View file
Open in desktop
Empty file.
29 changes: 29 additions & 0 deletions python/ql/test/library-tests/InlineExpectationsTest/learn-edits/Test.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import python
import utils.test.InlineExpectationsTest

module DirectTest implements TestSig {
string getARelevantTag() { result = "direct" }

string getARelevantExpectedTag() { result = ["direct", "direct[alias]"] }

bindingset[expectedTag, actualTag]
predicate tagMatches(string expectedTag, string actualTag) {
expectedTag = ["direct", "direct[alias]"] and actualTag = "direct"
}

predicate hasActualResult(Location location, string element, string tag, string value) {
exists(Name name |
name.getId() = ["target", "target_continuation"] and
location = name.getLocation() and
element = name.toString() and
tag = "direct" and
value = ""
)
}
}

private module Test = MakeTest<DirectTest>;

from string file, int line, string operation, int startColumn, int endColumn, string text
where Test::learnEdits(file, line, operation, startColumn, endColumn, text)
select file, line, operation, startColumn, endColumn, text
3 changes: 3 additions & 0 deletions python/ql/test/library-tests/InlineExpectationsTest/learn-edits/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
target = 1 # $ direct[alias] foreign
target_continuation = 1 \
+ 1
Loading
Loading