task 57: ->remove($selector) doesn't respect $selector

tobiasz.cudnik · tobiasz.cudnik · commit 669269e5ad7f · 2008-10-07T10:14:45.000Z
http://code.google.com/p/phpquery/issues/detail?id=57 git-svn-id: http://phpquery.googlecode.com/svn/branches/dev@201 afc5ee8f-4a33-0410-9214-8715c29b7d85
diff --git a/phpQuery/phpQuery.php b/phpQuery/phpQuery.php
@@ -2616,8 +2616,11 @@ public function replaceAll($selector) {
 	 *
 	 * @return phpQueryObject|queryTemplatesFetch|queryTemplatesParse|queryTemplatesPickup
 	 */
-	public function remove() {
-		foreach( $this->elements as $node ) {
+	public function remove($selector = null) {
+		$loop = $selector
+			? $this->filter($selector)->elements
+			: $this->elements;
+		foreach($loop as $node) {
 			if (! $node->parentNode )
 				continue;
 			$this->debug("Removing '{$node->tagName}'");
