Skip to content

Release 1.4.0#857

Merged
tcojean merged 3 commits into
developfrom
release/1.4.0
Aug 20, 2021
Merged

Release 1.4.0#857
tcojean merged 3 commits into
developfrom
release/1.4.0

Conversation

@tcojean

@tcojean tcojean commented Aug 10, 2021

Copy link
Copy Markdown
Member

This is the release preparation branch. For now, mostly to run the pipeline and check everything is OK

@tcojean tcojean added 1:ST:ready-for-review This PR is ready for review 1:ST:run-full-test labels Aug 10, 2021
@tcojean tcojean self-assigned this Aug 10, 2021
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. reg:ci-cd This is related to the continuous integration system. reg:documentation This is related to documentation. labels Aug 10, 2021

@Slaedr Slaedr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I have some comments below.

Comment thread third_party/gtest/CMakeLists.txt Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md
Comment thread third_party/gtest/CMakeLists.txt Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated

@pratikvn pratikvn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread README.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
@upsj upsj added this to the Ginkgo 1.4.0 milestone Aug 11, 2021
@tcojean tcojean force-pushed the release/1.4.0 branch 2 times, most recently from 241bc45 to a6c68b0 Compare August 11, 2021 11:01
@codecov

codecov Bot commented Aug 13, 2021

Copy link
Copy Markdown

Codecov Report

Merging #857 (c053a88) into develop (f77cfa8) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #857      +/-   ##
===========================================
+ Coverage    94.39%   94.41%   +0.01%     
===========================================
  Files          416      416              
  Lines        33217    33217              
===========================================
+ Hits         31356    31361       +5     
+ Misses        1861     1856       -5     
Impacted Files Coverage Δ
omp/reorder/rcm_kernels.cpp 97.53% <0.00%> (+3.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f77cfa8...c053a88. Read the comment docs.

Terry Cojean and others added 3 commits August 18, 2021 17:02
Co-authored-by: Yu-Hsiang Tsai <yhmtsai@gmail.com>
Co-authored-by: Aditya Kashi <aditya.kashi@kit.edu>
Co-authored-by: Pratik Nayak <pratikvn@protonmail.com>
@tcojean tcojean added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review 1:ST:run-full-test labels Aug 18, 2021
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tcojean tcojean merged commit f46cd79 into develop Aug 20, 2021
@tcojean tcojean deleted the release/1.4.0 branch August 20, 2021 08:32
@hartwiganzt

Copy link
Copy Markdown
Collaborator

Congrats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1:ST:ready-to-merge This PR is ready to merge. reg:build This is related to the build system. reg:ci-cd This is related to the continuous integration system. reg:documentation This is related to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants