Fix norm-type in the examples by thoasm · Pull Request #612 · ginkgo-project/ginkgo

thoasm · 2020-08-03T15:20:41Z

This PR updates the examples to always use a non-complex type for norms and makes sure that most of them compile and run properly with both std::complex<double> and double as ValueType.

Additionally done:

Update the expected result in the documentation.
Removed 27pt stencil example completely (since the error of the result is quite high)

Fixes #606

upsj

LGTM! Can you maybe double-check why so many of our residuals became worse? Did we change the stopping criteria and forget to adapt the output?

codecov · 2020-08-03T19:20:29Z

Codecov Report

Merging #612 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #612   +/-   ##
========================================
  Coverage    93.00%   93.00%           
========================================
  Files          296      296           
  Lines        20660    20660           
========================================
  Hits         19215    19215           
  Misses        1445     1445

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd043ef...20a044f. Read the comment docs.

yhmtsai

LGTM. some tests are much slower than previous. Could you run them again? or is original result on cuda executor?

pratikvn

LGTM!

thoasm · 2020-08-10T10:14:01Z

I just removed the 27pt stencil example, updated the timing output from the examples and rebased it.

The example output was previously done on a laptop in debug mode. Now, it was performed on a PC in release mode to be representative (performance is usually always measured in release mode).

sonarqubecloud · 2020-08-11T13:52:56Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
3 Code Smells

0.0% Coverage
24.2% Duplication

The version of Java (1.8.0_121) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

Release 1.3.0 of Ginkgo. The Ginkgo team is proud to announce the new minor release of Ginkgo version 1.3.0. This release brings CUDA 11 support, changes the default C++ standard to be C++14 instead of C++11, adds a new Diagonal matrix format and capacity for diagonal extraction, significantly improves the CMake configuration output format, adds the Ginkgo paper which got accepted into the Journal of Open Source Software (JOSS), and fixes multiple issues. Supported systems and requirements: + For all platforms, cmake 3.9+ + Linux and MacOS + gcc: 5.3+, 6.3+, 7.3+, all versions after 8.1+ + clang: 3.9+ + Intel compiler: 2017+ + Apple LLVM: 8.0+ + CUDA module: CUDA 9.0+ + HIP module: ROCm 2.8+ + Windows + MinGW and Cygwin: gcc 5.3+, 6.3+, 7.3+, all versions after 8.1+ + Microsoft Visual Studio: VS 2017 15.7+ + CUDA module: CUDA 9.0+, Microsoft Visual Studio + OpenMP module: MinGW or Cygwin. The current known issues can be found in the [known issues page](https://github.com/ginkgo-project/ginkgo/wiki/Known-Issues). Additions: + Add paper for Journal of Open Source Software (JOSS). [#479](#479) + Add a DiagonalExtractable interface. [#563](#563) + Add a new diagonal Matrix Format. [#580](#580) + Add Cuda11 support. [#603](#603) + Add information output after CMake configuration. [#610](#610) + Add a new preconditioner export example. [#595](#595) + Add a new cuda-memcheck CI job. [#592](#592) Changes: + Use unified memory in CUDA debug builds. [#621](#621) + Improve `BENCHMARKING.md` with more detailed info. [#619](#619) + Use C++14 standard instead of C++11. [#611](#611) + Update the Ampere sm information and CudaArchitectureSelector. [#588](#588) Fixes: + Fix documentation warnings and errors. [#624](#624) + Fix warnings for diagonal matrix format. [#622](#622) + Fix criterion factory parameters in CUDA. [#586](#586) + Fix the norm-type in the examples. [#612](#612) + Fix the WAW race in OpenMP is_sorted_by_column_index. [#617](#617) + Fix the example's exec_map by creating the executor only if requested. [#602](#602) + Fix some CMake warnings. [#614](#614) + Fix Windows building documentation. [#601](#601) + Warn when CXX and CUDA host compiler do not match. [#607](#607) + Fix reduce_add, prefix_sum, and doc-build. [#593](#593) + Fix find_library(cublas) issue on machines installing multiple cuda. [#591](#591) + Fix allocator in sellp read. [#589](#589) + Fix the CAS with HIP and NVIDIA backends. [#585](#585) Deletions: + Remove unused preconditioner parameter in LowerTrs. [#587](#587) Related PR: #625

The Ginkgo team is proud to announce the new minor release of Ginkgo version 1.3.0. This release brings CUDA 11 support, changes the default C++ standard to be C++14 instead of C++11, adds a new Diagonal matrix format and capacity for diagonal extraction, significantly improves the CMake configuration output format, adds the Ginkgo paper which got accepted into the Journal of Open Source Software (JOSS), and fixes multiple issues. Supported systems and requirements: + For all platforms, cmake 3.9+ + Linux and MacOS + gcc: 5.3+, 6.3+, 7.3+, all versions after 8.1+ + clang: 3.9+ + Intel compiler: 2017+ + Apple LLVM: 8.0+ + CUDA module: CUDA 9.0+ + HIP module: ROCm 2.8+ + Windows + MinGW and Cygwin: gcc 5.3+, 6.3+, 7.3+, all versions after 8.1+ + Microsoft Visual Studio: VS 2017 15.7+ + CUDA module: CUDA 9.0+, Microsoft Visual Studio + OpenMP module: MinGW or Cygwin. The current known issues can be found in the [known issues page](https://github.com/ginkgo-project/ginkgo/wiki/Known-Issues). Additions: + Add paper for Journal of Open Source Software (JOSS). [#479](#479) + Add a DiagonalExtractable interface. [#563](#563) + Add a new diagonal Matrix Format. [#580](#580) + Add Cuda11 support. [#603](#603) + Add information output after CMake configuration. [#610](#610) + Add a new preconditioner export example. [#595](#595) + Add a new cuda-memcheck CI job. [#592](#592) Changes: + Use unified memory in CUDA debug builds. [#621](#621) + Improve `BENCHMARKING.md` with more detailed info. [#619](#619) + Use C++14 standard instead of C++11. [#611](#611) + Update the Ampere sm information and CudaArchitectureSelector. [#588](#588) Fixes: + Fix documentation warnings and errors. [#624](#624) + Fix warnings for diagonal matrix format. [#622](#622) + Fix criterion factory parameters in CUDA. [#586](#586) + Fix the norm-type in the examples. [#612](#612) + Fix the WAW race in OpenMP is_sorted_by_column_index. [#617](#617) + Fix the example's exec_map by creating the executor only if requested. [#602](#602) + Fix some CMake warnings. [#614](#614) + Fix Windows building documentation. [#601](#601) + Warn when CXX and CUDA host compiler do not match. [#607](#607) + Fix reduce_add, prefix_sum, and doc-build. [#593](#593) + Fix find_library(cublas) issue on machines installing multiple cuda. [#591](#591) + Fix allocator in sellp read. [#589](#589) + Fix the CAS with HIP and NVIDIA backends. [#585](#585) Deletions: + Remove unused preconditioner parameter in LowerTrs. [#587](#587) Related PR: #627

thoasm added is:bug Something looks wrong. reg:documentation This is related to documentation. reg:example This is related to the examples. 1:ST:ready-for-review This PR is ready for review labels Aug 3, 2020

thoasm requested review from fritzgoebel, hartwiganzt, pratikvn, tcojean, upsj and yhmtsai August 3, 2020 15:20

thoasm self-assigned this Aug 3, 2020

thoasm changed the title ~~Fix example norms~~ Fix norm-type in the examples Aug 3, 2020

upsj approved these changes Aug 3, 2020

View reviewed changes

yhmtsai approved these changes Aug 4, 2020

View reviewed changes

pratikvn approved these changes Aug 10, 2020

View reviewed changes

Comment thread examples/inverse-iteration/inverse-iteration.cpp

thoasm force-pushed the fix_example_norms branch from 3354330 to c7bb3f4 Compare August 10, 2020 09:39

pratikvn mentioned this pull request Aug 10, 2020

[JOSS REVIEW] Functionality Review #597

Closed

16 tasks

Thomas Grützmacher added 5 commits August 11, 2020 12:43

Fix norm-issue in inverse-iteration example

8fcb07e

Update more examples to have the correct type for norms

840be0c

Update the remaining examples

4b9d9c2

Update example output (results.dox)

cf81526

Remove 27pt stencil example; Update timing output

20a044f

The example output was previously done on a laptop in debug mode. Now, it was performed on a PC in release mode to be representative (performance is usually always measured in release mode).

thoasm force-pushed the fix_example_norms branch from c7bb3f4 to 20a044f Compare August 11, 2020 10:43

upsj added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Aug 11, 2020

thoasm merged commit ef7a837 into develop Aug 12, 2020

thoasm deleted the fix_example_norms branch August 12, 2020 08:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix norm-type in the examples#612

Fix norm-type in the examples#612
thoasm merged 5 commits into
developfrom
fix_example_norms

thoasm commented Aug 3, 2020 •

edited

Loading

Uh oh!

upsj left a comment

Uh oh!

codecov Bot commented Aug 3, 2020 •

edited

Loading

Uh oh!

yhmtsai left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pratikvn left a comment

Uh oh!

Uh oh!

thoasm commented Aug 10, 2020

Uh oh!

sonarqubecloud Bot commented Aug 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

thoasm commented Aug 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

upsj left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Aug 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

yhmtsai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pratikvn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thoasm commented Aug 10, 2020

Uh oh!

sonarqubecloud Bot commented Aug 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thoasm commented Aug 3, 2020 •

edited

Loading

codecov Bot commented Aug 3, 2020 •

edited

Loading