Skip to content

Minor Release v1.1.1#406

Merged
tcojean merged 29 commits into
masterfrom
release/v1.1.1
Dec 2, 2019
Merged

Minor Release v1.1.1#406
tcojean merged 29 commits into
masterfrom
release/v1.1.1

Conversation

@tcojean

@tcojean tcojean commented Nov 27, 2019

Copy link
Copy Markdown
Member

TODO

  • fix sonarqube step problem
  • run full pipeline and generate documentation
  • ensure everything compiles properly on Windows
  • proofread documentation and changelog

CHANGELOG

This version of Ginkgo provides a few fixes in Ginkgo's core routines. The
supported systems and requirements are unchanged from version 1.1.0.

Fixes

  • Improve Ginkgo's installation and fix the test_install step (#406),
  • Fix some documentation issues (#406),
  • Fix multiple code issues reported by sonarqube (#406),
  • Update the git-cmake-format repository (#399),
  • Improve the global update header script (#390),
  • Fix broken bounds checks (#388),
  • Fix CSR strategies and improve performance (#379),
  • Fix a small typo in the stencil examples (#381),
  • Fix ELL error on small matrices (#375),
  • Fix SellP read function (#374),
  • Add factorization support in create_new_algorithm.sh (#371).

Thomas Grützmacher and others added 10 commits November 27, 2019 17:03
- All conversions to CSR (except CSR to CSR) now conserve the original
  strategy (test for that are included)
- CSR strategies now try to copy the least amount of data
- Add exception throwing in case the load_balance would not work
  properly (when srow is empty)
- Make strategy helper variables const to ensure they do not change
- Fix Hybrid read function
- GKO_NOT_SUPPORTED is the only macro that does not include the
  `throw`. This was not only a problem in this code, but also in
  unrelated code, which is also fixed within this commit
- An Empty Dense matrix can now be converted to a CSR matrix
- Moved the `GKO_NOT_SUPPORTED` to the cuda kernel, so empty matrices
  do not throw when applying a strategy.
- Change a `static_cast` in the strategies to a constructor call
- Move empty matrix test from CSR to Dense (and add a move test)
@tcojean tcojean added the 1:ST:ready-for-review This PR is ready for review label Nov 27, 2019
@tcojean tcojean self-assigned this Nov 27, 2019
@tcojean tcojean changed the base branch from develop to master November 27, 2019 16:36
upsj
upsj previously approved these changes Nov 27, 2019

@upsj upsj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small suggestion for simplifying the versioning.

Comment thread core/device_hooks/cuda_hooks.cpp Outdated
Terry Cojean and others added 11 commits November 27, 2019 18:12
`update_ginkgo_header.sh` now no longer returns a non-zero exit code,
meaning it should no longer stop the `make` process when something
goes wrong or is not found.
Additionally, the script is now only called if `GINKGO_DEVEL_TOOLS` are
enabled since non-developer would not benefit or need it.
- Add additional tests for access privileges
- Add `rm` parameter
Changed `rm` parameter to `-f` in order to have a wider OS support.
@tcojean tcojean force-pushed the release/v1.1.1 branch 2 times, most recently from 7a8bc8e to f881435 Compare November 29, 2019 09:29
@tcojean

tcojean commented Nov 29, 2019

Copy link
Copy Markdown
Member Author

@yhmtsai these should be fixed. There is also a jacobi documentation group btw, do I add a documentation header for this so that it appears as a module?

@tcojean

tcojean commented Nov 29, 2019

Copy link
Copy Markdown
Member Author

@yhmtsai, can you check whether compilation still works on windows? Thanks

@yhmtsai

yhmtsai commented Nov 29, 2019

Copy link
Copy Markdown
Member

@tcojean Sure, I can test it.
I need to wait my brother to open my laptop such that I can also test cuda kernel.

@pratikvn

pratikvn commented Nov 29, 2019

Copy link
Copy Markdown
Member

I just realized that we say in the tutorial that it is a 2D Poisson solver, whereas it is actually a 1D Poisson solver. We can just remove the 2D and just call it a Poisson solver. So, I think we should update the following:

  1. The main Doxygen page to https://github.com/ginkgo-project/ginkgo/wiki/Tutorial:-Building-a-Poisson-Solver

  2. The link in the Ginkgo webpage which redirects to the tutorial.

Any other places ?

yhmtsai
yhmtsai previously approved these changes Nov 29, 2019

@yhmtsai yhmtsai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It also passes the tests with CUDA and shared/static setting in Windows

@tcojean tcojean requested review from pratikvn and upsj November 29, 2019 15:51
pratikvn
pratikvn previously approved these changes Nov 29, 2019

@pratikvn pratikvn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

upsj
upsj previously approved these changes Dec 2, 2019

@upsj upsj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tcojean tcojean dismissed stale reviews from upsj, pratikvn, and yhmtsai via c8ec186 December 2, 2019 09:53
@tcojean

tcojean commented Dec 2, 2019

Copy link
Copy Markdown
Member Author

Reviews got dismissed again? Sorry about that, I guess I need to find a better way to generate documentation for the release branches.

@pratikvn pratikvn self-requested a review December 2, 2019 10:54

@pratikvn pratikvn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tcojean tcojean merged commit 08d2c52 into master Dec 2, 2019
tcojean added a commit that referenced this pull request Dec 3, 2019
Minor release v1.1.1

This version of Ginkgo provides a few fixes in Ginkgo's core routines. The
supported systems and requirements are unchanged from version 1.1.0.

### Fixes
+ Fix the `test_install` step with `HIP` ([#409](#409)),
+ Improve Ginkgo's installation and fix the `test_install` step ([#406](#406)),
+ Fix some documentation issues ([#406](#406)),
+ Fix multiple code issues reported by sonarqube ([#406](#406)),
+ Update the git-cmake-format repository ([#399](#399)),
+ Improve the global update header script ([#390](#390)),
+ Fix broken bounds checks ([#388](#388)),
+ Fix CSR strategies and improve performance ([#379](#379)),
+ Fix a small typo in the stencil examples ([#381](#381)),
+ Fix ELL error on small matrices ([#375](#375)),
+ Fix SellP read function ([#374](#374)),
+ Add factorization support in `create_new_algorithm.sh`  ([#371](#371))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1:ST:ready-for-review This PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants