Improve update header#390
Merged
Merged
Conversation
tcojean
requested changes
Nov 18, 2019
tcojean
left a comment
Member
There was a problem hiding this comment.
LGTM. But do not use the --interactive=never parameter.
tcojean
reviewed
Nov 18, 2019
tcojean
approved these changes
Nov 18, 2019
yhmtsai
approved these changes
Nov 19, 2019
yhmtsai
left a comment
Member
There was a problem hiding this comment.
LGTM. only need to rebase on the develop. include/ginkgo/ginkgo.hpp is already fixed.
added 3 commits
November 19, 2019 14:08
`update_ginkgo_header.sh` now no longer returns a non-zero exit code, meaning it should no longer stop the `make` process when something goes wrong or is not found. Additionally, the script is now only called if `GINKGO_DEVEL_TOOLS` are enabled since non-developer would not benefit or need it.
- Add additional tests for access privileges - Add `rm` parameter
Changed `rm` parameter to `-f` in order to have a wider OS support.
4c3fba1 to
76d4fb8
Compare
tcojean
added a commit
that referenced
this pull request
Dec 2, 2019
This version of Ginkgo provides a few fixes in Ginkgo's core routines. The supported systems and requirements are unchanged from version 1.1.0. ### Fixes + Improve Ginkgo's installation and fix the `test_install` step ([#406](#406)), + Fix some documentation issues ([#406](#406)), + Fix multiple code issues reported by sonarqube ([#406](#406)), + Update the git-cmake-format repository ([#399](#399)), + Improve the global update header script ([#390](#390)), + Fix broken bounds checks ([#388](#388)), + Fix CSR strategies and improve performance ([#379](#379)), + Fix a small typo in the stencil examples ([#381](#381)), + Fix ELL error on small matrices ([#375](#375)), + Fix SellP read function ([#374](#374)), + Add factorization support in `create_new_algorithm.sh` ([#371](#371)).
tcojean
added a commit
that referenced
this pull request
Dec 3, 2019
Minor release v1.1.1 This version of Ginkgo provides a few fixes in Ginkgo's core routines. The supported systems and requirements are unchanged from version 1.1.0. ### Fixes + Fix the `test_install` step with `HIP` ([#409](#409)), + Improve Ginkgo's installation and fix the `test_install` step ([#406](#406)), + Fix some documentation issues ([#406](#406)), + Fix multiple code issues reported by sonarqube ([#406](#406)), + Update the git-cmake-format repository ([#399](#399)), + Improve the global update header script ([#390](#390)), + Fix broken bounds checks ([#388](#388)), + Fix CSR strategies and improve performance ([#379](#379)), + Fix a small typo in the stencil examples ([#381](#381)), + Fix ELL error on small matrices ([#375](#375)), + Fix SellP read function ([#374](#374)), + Add factorization support in `create_new_algorithm.sh` ([#371](#371))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents the script
update_ginkgo_header.shfrom stopping the building procedure by only printing WARNINGs instead of exiting with an error code (which, apparently, cancels the whole building all together).Additionally, the script is now only performed when the
GINKGO_DEVEL_TOOLSare enabled (otherwise, the script is not run).Finally, some more tests were added to provide detailed warnings.