Improve the exception in the config#1944
Merged
Merged
Conversation
upsj
approved these changes
Oct 31, 2025
upsj
left a comment
Member
There was a problem hiding this comment.
LGTM! Can you maybe add a before/after error message to the PR description?
Member
Author
|
@upsj Yes, will do when I finish the work. |
pratikvn
approved these changes
Nov 7, 2025
pratikvn
left a comment
Member
There was a problem hiding this comment.
Thanks. I also ran into this with OpenCARP, so it will be useful there as well.
4f74abc to
3cc6469
Compare
Member
Author
Member
|
Thanks! looks much better, indeed :) |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It improves the exception information from the wrong config.
When give the wrong key in type, (I use "type": "Invalid" as test case)
Original exception:
map::atUpdated exception:
core/config/config.cpp:<line>: parse: Invalid state encountered : The value >Invalid< is invalid for the entry >type<