Fix bug in assembly for GPU-aware MPI#1887
Merged
Merged
Conversation
MarcelKoch
approved these changes
Jul 16, 2025
MarcelKoch
left a comment
Member
There was a problem hiding this comment.
I think we would need a more robust handling for this in the future.
yhmtsai
approved these changes
Jul 16, 2025
Member
|
@fritzgoebel, maybe you can rebase and merge this ? |
2f7b870 to
a3d26b3
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These distinctions are the wrong way around, causing failures when using
assemble_rows_from_neighborswith GPU-aware MPI.