Fix stride for GCR initialization#1656
Merged
Merged
Conversation
MarcelKoch
approved these changes
Jul 30, 2024
pratikvn
approved these changes
Jul 30, 2024
Member
Author
|
@yhmtsai exactly, the residual uses the default stride, while b can have an arbitrary stride |
Member
|
Error: PR already merged! |
MarcelKoch
pushed a commit
to MarcelKoch/ginkgo
that referenced
this pull request
Dec 2, 2024
This fixes a stride-related bug in GCR kernels. Related PR: ginkgo-project#1656
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed by @nbeams, the GCR initialization kernel uses an incorrect stride. This fixes it and adds a test for the behavior.