Skip to content

Commit b4be2be

Browse files
author
tcojean
authored
Merge Release 1.2.0
The Ginkgo team is proud to announce the new minor release of Ginkgo version 1.2.0. This release brings full HIP support to Ginkgo, new preconditioners (ParILUT, ISAI), conversion between double and float for all LinOps, and many more features and fixes. Supported systems and requirements: + For all platforms, cmake 3.9+ + Linux and MacOS + gcc: 5.3+, 6.3+, 7.3+, all versions after 8.1+ + clang: 3.9+ + Intel compiler: 2017+ + Apple LLVM: 8.0+ + CUDA module: CUDA 9.0+ + HIP module: ROCm 2.8+ + Windows + MinGW and CygWin: gcc 5.3+, 6.3+, 7.3+, all versions after 8.1+ + Microsoft Visual Studio: VS 2017 15.7+ + CUDA module: CUDA 9.0+, Microsoft Visual Studio + OpenMP module: MinGW or CygWin. The current known issues can be found in the [known issues page](https://github.com/ginkgo-project/ginkgo/wiki/Known-Issues). # Additions Here are the main additions to the Ginkgo library. Other thematic additions are listed below. + Add full HIP support to Ginkgo [#344](#344), [#357](#357), [#384](#384), [#373](#373), [#391](#391), [#396](#396), [#395](#395), [#393](#393), [#404](#404), [#439](#439), [#443](#443), [#567](#567) + Add a new ISAI preconditioner [#489](#489), [#502](#502), [#512](#512), [#508](#508), [#520](#520) + Add support for ParILUT and ParICT factorization with ILU preconditioners [#400](#400) + Add a new BiCG solver [#438](#438) + Add a new permutation matrix format [#352](#352), [#469](#469) + Add CSR SpGEMM support [#386](#386), [#398](#398), [#418](#418), [#457](#457) + Add CSR SpGEAM support [#556](#556) + Make all solvers and preconditioners transposable [#535](#535) + Add CsrBuilder and CooBuilder for intrusive access to matrix arrays [#437](#437) + Add a standard-compliant allocator based on the Executors [#504](#504) + Support conversions for all LinOp between double and float [#521](#521) + Add a new boolean to the CUDA and HIP executors to control DeviceReset (default off) [#557](#557) + Add a relaxation factor to IR to represent Richardson Relaxation [#574](#574) + Add two new stopping criteria, for relative (to `norm(b)`) and absolute residual norm [#577](#577) ### Example additions + Templatize all examples to simplify changing the precision [#513](#513) + Add a new adaptive precision block-Jacobi example [#507](#507) + Add a new IR example [#522](#522) + Add a new Mixed Precision Iterative Refinement example [#525](#525) + Add a new example on iterative trisolves in ILU preconditioning [#526](#526), [#536](#536), [#550](#550) ### Compilation and library changes + Auto-detect compilation settings based on environment [#435](#435), [#537](#537) + Add SONAME to shared libraries [#524](#524) + Add clang-cuda support [#543](#543) ### Other additions + Add sorting, searching and merging kernels for GPUs [#403](#403), [#428](#428), [#417](#417), [#455](#455) + Add `gko::as` support for smart pointers [#493](#493) + Add setters and getters for criterion factories [#527](#527) + Add a new method to check whether a solver uses `x` as an initial guess [#531](#531) + Add contribution guidelines [#549](#549) # Fixes ### Algorithms + Improve the classical CSR strategy's performance [#401](#401) + Improve the CSR automatical strategy [#407](#407), [#559](#559) + Memory, speed improvements to the ELL kernel [#411](#411) + Multiple improvements and fixes to ParILU [#419](#419), [#427](#427), [#429](#429), [#456](#456), [#544](#544) + Fix multiple issues with GMRES [#481](#481), [#523](#523), [#575](#575) + Optimize OpenMP matrix conversions [#505](#505) + Ensure the linearity of the ILU preconditioner [#506](#506) + Fix IR's use of the advanced apply [#522](#522) + Fix empty matrices conversions and add tests [#560](#560) ### Other core functionalities + Fix complex number support in our math header [#410](#410) + Fix CUDA compatibility of the main ginkgo header [#450](#450) + Fix isfinite issues [#465](#465) + Fix the Array::view memory leak and the array/view copy/move [#485](#485) + Fix typos preventing use of some interface functions [#496](#496) + Fix the `gko::dim` to abide to the C++ standard [#498](#498) + Simplify the executor copy interface [#516](#516) + Optimize intermediate storage for Composition [#540](#540) + Provide an initial guess for relevant Compositions [#561](#561) + Better management of nullptr as criterion [#562](#562) + Fix the norm calculations for complex support [#564](#564) ### CUDA and HIP specific + Use the return value of the atomic operations in our wrappers [#405](#405) + Improve the portability of warp lane masks [#422](#422) + Extract thread ID computation into a separate function [#464](#464) + Reorder kernel parameters for consistency [#474](#474) + Fix the use of `pragma unroll` in HIP [#492](#492) ### Other + Fix the Ginkgo CMake installation files [#414](#414), [#553](#553) + Fix the Windows compilation [#415](#415) + Always use demangled types in error messages [#434](#434), [#486](#486) + Add CUDA header dependency to appropriate tests [#452](#452) + Fix several sonarqube or compilation warnings [#453](#453), [#463](#463), [#532](#532), [#569](#569) + Add shuffle tests [#460](#460) + Fix MSVC C2398 error [#490](#490) + Fix missing interface tests in test install [#558](#558) # Tools and ecosystem ### Benchmarks + Add better norm support in the benchmarks [#377](#377) + Add CUDA 10.1 generic SpMV support in benchmarks [#468](#468), [#473](#473) + Add sparse library ILU in benchmarks [#487](#487) + Add overhead benchmarking capacities [#501](#501) + Allow benchmarking from a matrix list file [#503](#503) + Fix benchmarking issue with JSON and non-finite numbers [#514](#514) + Fix benchmark logger crashers with OpenMP [#565](#565) ### CI related + Improvements to the CI setup with HIP compilation [#421](#421), [#466](#466) + Add MacOSX CI support [#470](#470), [#488](#488) + Add Windows CI support [#471](#471), [#488](#488), [#510](#510), [#566](#566) + Use sanitizers instead of valgrind [#476](#476) + Add automatic container generation and update facilities [#499](#499) + Fix the CI parallelism settings [#517](#517), [#538](#538), [#539](#539) + Make the codecov patch check informational [#519](#519) + Add support for LLVM sanitizers with improved thread sanitizer support [#578](#578) ### Test suite + Add an assertion for sparsity pattern equality [#416](#416) + Add core and reference multiprecision tests support [#448](#448) + Speed up GPU tests by avoiding device reset [#467](#467) + Change test matrix location string [#494](#494) ### Other + Add Ginkgo badges from our tools [#413](#413) + Update the `create_new_algorithm.sh` script [#420](#420) + Bump copyright and improve license management [#436](#436), [#433](#433) + Set clang-format minimum requirement [#441](#441), [#484](#484) + Update git-cmake-format [#446](#446), [#484](#484) + Disable the development tools by default [#442](#442) + Add a script for automatic header formatting [#447](#447) + Add GDB pretty printer for `gko::Array` [#509](#509) + Improve compilation speed [#533](#533) + Add editorconfig support [#546](#546) + Add a compile-time check for header self-sufficiency [#552](#552) # Related PR: #583
2 parents 08d2c52 + cb29b44 commit b4be2be

810 files changed

Lines changed: 79792 additions & 14069 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.editorconfig‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
# More info: https://editorconfig.org
2+
3+
# top-most EditorConfig file
4+
root = true
5+
6+
# Use space and 4 indentation style everywhere.
7+
# Also add a newline at the end of every file.
8+
[*]
9+
charset = utf-8
10+
end_of_line = lf
11+
insert_final_newline = true
12+
trim_trailing_whitespace = true
13+
indent_style = space
14+
indent_size = 4
15+
16+
# YAML files use 2 space indentation for now.
17+
[*.{yml,md}]
18+
indent_style = space
19+
indent_size = 2
20+
21+
# Makefiles require tabs
22+
[Makefile]
23+
indent_style = tab

‎.github/workflows/osx.yml‎

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
name: OSX-build
2+
3+
on: [push]
4+
5+
jobs:
6+
osx-clang-omp:
7+
strategy:
8+
fail-fast: false
9+
matrix:
10+
config:
11+
- {shared: "ON", build_type: "Debug", name: "omp/debug/shared"}
12+
- {shared: "OFF", build_type: "Release", name: "omp/release/static"}
13+
name: ${{ matrix.config.name }}
14+
runs-on: [macos-latest]
15+
16+
steps:
17+
- uses: actions/checkout@v2
18+
- name: setup
19+
run: brew install libomp
20+
- name: info
21+
run: |
22+
g++ -v
23+
cmake --version
24+
- name: configure
25+
run: |
26+
mkdir build
27+
cd build
28+
cmake .. -DBUILD_SHARED_LIBS=${{ matrix.config.shared }} -DCMAKE_BUILD_TYPE=${{ matrix.config.build_type }}
29+
make -j8
30+
ctest -j10 --output-on-failure
31+
- name: install
32+
run: |
33+
cd build
34+
make install
35+
make test_install

‎.github/workflows/windows-build.yml‎

Lines changed: 158 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,158 @@
1+
name: Windows-build
2+
3+
on: [push]
4+
5+
jobs:
6+
windows_cuda:
7+
name: cuda102/release/shared (only compile)
8+
runs-on: [windows-latest]
9+
steps:
10+
- uses: actions/checkout@v2
11+
- name: setup
12+
run: |
13+
choco install cuda --version=10.2.89.20191206 -y
14+
- name: configure
15+
run: |
16+
$env:ChocolateyInstall = Convert-Path "$((Get-Command choco).Path)\..\.."
17+
Import-Module "$env:ChocolateyInstall\helpers\chocolateyProfile.psm1"
18+
refreshenv
19+
mkdir build
20+
cd build
21+
$env:PATH="$pwd\windows_shared_library;$env:PATH"
22+
cmake -DGINKGO_BUILD_CUDA=ON -DGINKGO_BUILD_OMP=OFF ..
23+
cmake --build . -j4 --config Release
24+
25+
windows_ref:
26+
strategy:
27+
fail-fast: false
28+
matrix:
29+
config:
30+
- {shared: "ON", build_type: "Debug", name: "reference/debug/shared"}
31+
- {shared: "OFF", build_type: "Release", name: "reference/release/static"}
32+
# Debug static needs too much storage
33+
# - {shared: "OFF", build_type: "Debug", name: "reference/debug/static"}
34+
name: msvc/${{ matrix.config.name }}
35+
runs-on: [windows-latest]
36+
steps:
37+
- uses: actions/checkout@v2
38+
- name: shared_env
39+
if: matrix.config.shared == 'ON'
40+
run: |
41+
echo "::set-env name=origin_path::$env:PATH"
42+
echo "::add-path::$pwd\build\windows_shared_library"
43+
- name: debug_env
44+
if: matrix.config.build_type == 'Debug'
45+
run: |
46+
echo "::set-env name=CXXFLAGS::/bigobj"
47+
- name: configure
48+
run: |
49+
mkdir build
50+
cd build
51+
cmake -DBUILD_SHARED_LIBS=${{ matrix.config.shared }} -DGINKGO_BUILD_CUDA=OFF -DGINKGO_BUILD_OMP=OFF ..
52+
cmake --build . -j4 --config ${{ matrix.config.build_type }}
53+
ctest . -C ${{ matrix.config.build_type }} --output-on-failure
54+
- name: install_shared_env
55+
if: matrix.config.shared == 'ON'
56+
run: |
57+
echo "::set-env name=PATH::C:\Program Files (x86)\Ginkgo\lib;$env:origin_path"
58+
- name: install
59+
run: |
60+
cd build
61+
cmake --install . --config ${{ matrix.config.build_type }}
62+
cmake --build . --target test_install --config ${{ matrix.config.build_type }}
63+
windows_mingw:
64+
strategy:
65+
fail-fast: false
66+
matrix:
67+
config:
68+
- {shared: "ON", build_type: "Debug", name: "omp/debug/shared", cflags: "-O1"}
69+
- {shared: "OFF", build_type: "Release", name: "omp/release/static", cflags: ""}
70+
name: mingw/${{ matrix.config.name }}
71+
runs-on: [windows-latest]
72+
steps:
73+
- uses: actions/checkout@v2
74+
- name: shared_env
75+
if: matrix.config.shared == 'ON'
76+
run: |
77+
echo "::set-env name=origin_path::$env:PATH"
78+
echo "::add-path::$pwd\build\windows_shared_library"
79+
- name: debug_env
80+
if: matrix.config.build_type == 'Debug'
81+
run: |
82+
echo "::set-env name=CXXFLAGS::-Wa,-mbig-obj"
83+
- name: configure
84+
# Use cmd to remove the path easily
85+
run: |
86+
set PATH=%PATH:C:\Program Files\Git\bin;=%
87+
set PATH=%PATH:C:\Program Files\Git\usr\bin;=%
88+
bcdedit /set IncreaseUserVa 3072
89+
editbin /LARGEADDRESSAWARE "C:\Program Files\Git\mingw64\bin\cc1plus.exe"
90+
mkdir build
91+
cd build
92+
cmake -G "MinGW Makefiles" -DBUILD_SHARED_LIBS=${{ matrix.config.shared }} -DCMAKE_BUILD_TYPE=${{ matrix.config.build_type }} -DGINKGO_COMPILER_FLAGS=${{ matrix.config.cflags }} ..
93+
cmake --build . -j4
94+
ctest . --output-on-failure
95+
shell: cmd
96+
- name: install_shared_env
97+
if: matrix.config.shared == 'ON'
98+
run: |
99+
echo "::set-env name=PATH::C:\Program Files (x86)\Ginkgo\lib;$env:origin_path"
100+
- name: install
101+
run: |
102+
set PATH=%PATH:C:\Program Files\Git\bin;=%
103+
set PATH=%PATH:C:\Program Files\Git\usr\bin;=%
104+
cd build
105+
cmake --install .
106+
cmake --build . --target test_install
107+
shell: cmd
108+
109+
windows_cygwin:
110+
strategy:
111+
fail-fast: false
112+
matrix:
113+
config:
114+
- {shared: "ON", build_type: "Debug", name: "omp/debug/shared", cflags: "-O1"}
115+
- {shared: "OFF", build_type: "Release", name: "omp/release/static", cflags: ""}
116+
name: cygwin/${{ matrix.config.name }}
117+
runs-on: [windows-latest]
118+
steps:
119+
- run: git config --global core.autocrlf input
120+
- uses: actions/checkout@v2
121+
- name: setup
122+
run: |
123+
choco install cygwin -y
124+
choco install cyg-get -y
125+
cyg-get cmake make gcc-g++ git
126+
- name: shared_static_env
127+
run: |
128+
echo "::set-env name=shared_ON_path::;$pwd\build\windows_shared_library"
129+
echo "::set-env name=shared_OFF_path::"
130+
- name: debug_env
131+
if: matrix.config.build_type == 'Debug'
132+
run: |
133+
echo "::set-env name=CXXFLAGS::-Wa,-mbig-obj"
134+
- name: configure
135+
run: |
136+
path C:\tools\cygwin\bin%shared_${{ matrix.config.shared }}_path%
137+
mkdir build
138+
cd build
139+
bash -c "cmake -DBUILD_SHARED_LIBS=${{ matrix.config.shared }} -DCMAKE_BUILD_TYPE=${{ matrix.config.build_type }} -DGINKGO_COMPILER_FLAGS=${{ matrix.config.cflags }} .."
140+
bash -c "make -j4"
141+
bash -c "ctest . --output-on-failure"
142+
shell: cmd
143+
- name: install_shared
144+
if: matrix.config.shared == 'ON'
145+
run: |
146+
path C:\tools\cygwin\bin
147+
cd build
148+
bash -c "make install"
149+
bash -c "export PATH=/usr/local/lib:$PATH && make test_install"
150+
shell: cmd
151+
- name: install_static
152+
if: matrix.config.shared == 'OFF'
153+
run: |
154+
path C:\tools\cygwin\bin
155+
cd build
156+
bash -c "make install"
157+
bash -c "make test_install"
158+
shell: cmd

0 commit comments

Comments
 (0)