fix(sdk,python): clarify ignoring loggers#18293
Open
mfocko wants to merge 1 commit into
Open
Conversation
|
@mfocko is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
Add an alert with a tip for ignoring loggers altogether when using the Sentry logs collection. Using only the `ignore_logger` results in behaviour that is described in the docstrings, but not in the official docs themselves which has surprised me at first. Therefore add a more comprehensive explanation to the docs that are first hit when setting up the Sentry. Signed-off-by: Matej Focko <me@mfocko.xyz>
40b9654 to
549357d
Compare
sentrivana
approved these changes
Jun 9, 2026
Contributor
|
Thanks @mfocko, the PR looks good to me! @coolguyzone I don't have the permissions to run the Vercel build, could you do that please? From my side good to merge. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Add an alert with a tip for ignoring loggers altogether when using the Sentry logs collection. Using only the
ignore_loggerresults in behaviour that is described in the docstrings, but not in the official docs themselves which has surprised me at first.Therefore add a more comprehensive explanation to the docs that are the “first hit” when setting up the Sentry.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES