dataconnect(change): internal refactor of connectorResourceName variable names#8025
Conversation
…ame" [skip actions]
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request performs an internal refactor to improve code clarity by renaming variables to be more descriptive. Specifically, 'requestName' was renamed to 'connectorResourceName' in 'DataConnectGrpcClient.kt', with corresponding updates made to the unit tests. I have no feedback to provide as there are no review comments.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Adds daily test status to the Test Reporting bug. Unlike unit and instrumentation tests, all runs are always shown, since we currently only have 1 type of daily test. Example output below. ----- ### Unit Tests | | [#8009](#8009) | [#7983](#7983) | [#8002](#8002) | [#8027](#8027) | [#8028](#8028) | [#8025](#8025) | Success Rate | | :--- | :---: | :---: | :---: | :---: | :---: | :---: | :--- | | firebase-dataconnect | | | | [✅](https://github.com/firebase/firebase-android-sdk/actions/runs/24202345424/job/70649528040) | | [⛔](https://github.com/firebase/firebase-android-sdk/actions/runs/24162429246/job/70516856982) | ⛔ 50% | *+8 passing SDKs ### Instrumentation Tests *All tests passing* ### Daily Tests | | Apr 15 | Apr 16 | Apr 17 | Apr 18 | Apr 19 | Apr 20 | Apr 21 | Success Rate | | :--- | :---: | :---: | :---: | :---: | :---: | :---: | :---: | :--- | | AI Daily Tests | [✅](https://github.com/firebase/firebase-android-sdk/actions/runs/24442505713) | [✅](https://github.com/firebase/firebase-android-sdk/actions/runs/24498252859) | [✅](https://github.com/firebase/firebase-android-sdk/actions/runs/24553833385) | [✅](https://github.com/firebase/firebase-android-sdk/actions/runs/24599892175) | [✅](https://github.com/firebase/firebase-android-sdk/actions/runs/24623963356) | [✅](https://github.com/firebase/firebase-android-sdk/actions/runs/24654541730) | [✅](https://github.com/firebase/firebase-android-sdk/actions/runs/24710324995) | ✅ 100% |
Internal refactor in the Data Connect SDK to improve code clarity by renaming variables related to the connector resource name.
Highlights
requestNametoconnectorResourceNameinDataConnectGrpcClientto more accurately reflect its contents.CHANGELOG.mddocumenting the change.Changelog
Details
requestNameproperty and its usages toconnectorResourceName.expectedNametoexpectedConnectorResourceName.