Implement Maps Grounding#7950
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request implements support for Maps Grounding in Firebase AI. The changes include adding new data classes like GoogleMaps, LatLng, MapsGroundingChunk, and RetrievalConfig, and updating existing ones like Tool and GroundingChunk to support the new functionality. New tests have been added to verify the implementation.
My review focuses on improving code clarity, adhering to Kotlin best practices, and fixing issues in documentation and tests. I've identified several areas for minor refactoring, such as removing redundant modifiers and improving KDoc formatting. I also found a potential bug in a serialization test and a non-idiomatic DSL builder implementation. Overall, the changes are well-structured and implement the intended feature.
…alizationTests.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…e/ai/GroundingTests.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…pe/Candidate.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…pe/Candidate.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…pe/LatLng.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…pe/RetrievalConfig.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…pe/Tool.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
The public api surface has changed for the subproject ai-logic_firebase-ai: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Implements support for Maps Grounding, enabling using Google Maps in
queries both with semantic logic ("what is in [city]?") and positional
logic ("where am I?" combined with latitude/longitude coordinates).
---------
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This reverts commit 16cb887.
Implements support for Maps Grounding, enabling using Google Maps in queries both with semantic logic ("what is in [city]?") and positional logic ("where am I?" combined with latitude/longitude coordinates).