[web-console] Brighten source-range highlight in profiler SQL view#6462
Merged
Conversation
mihaibudiu
approved these changes
Jun 13, 2026
mihaibudiu
left a comment
Contributor
There was a problem hiding this comment.
Can navigation be done with single click?
Contributor
Author
|
We discussed with Leonid that I'll revise the triggers for interaction (click/doubleclick etc.) as a separate issue |
Contributor
How will users discover this? At least update the documentation I wrote about the profiler. |
mythical-fred
approved these changes
Jun 13, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM — clean approach, good tests.
6fc26dc to
b07b1e6
Compare
Closes #6404. Clicking a node with a source position in the profiler diagram calls Monaco's `setSelections` to highlight the matching SQL range, but the editor is read-only and never focused, so Monaco rendered the selection with its faint "inactive" colour (vs: #E5EBF1, vs-dark: #3A3D41) — the user could barely tell anything had been selected. Register the same `feldera-light` / `feldera-dark` Monaco themes the pipeline editor (`CodeEditor.svelte`) already uses: they override `editor.inactiveSelectionBackground` to a saturated blue with substantial alpha. Defining the themes again here is safe — `monaco.editor.defineTheme` is idempotent and the values match — and unit tests pin both halves of the contract. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is existing functionality to navigate to SQL source position when double-clicking the profile diagram node, but the highlight was very faint. This PR makes the highlight color stand out, and has editor on the pipeline page match it
Testing: manual, added unit tests
Fix #6404