[adapters] Delta transaction_mode:snapshot regression.#6417
Merged
Conversation
When introducing catchup mode, I accidentally made a change that broke the `snapshot` mode, specifically, the connector didn't start a transaction to ingest a snapshot, as expected. The commit fixes, the bug, adds a test that would have caught it and also fixes the implementation of the number-of-snapshot-transactions metric, which was introduced in the catchup PR. Signed-off-by: Leonid Ryzhyk <ryzhyk@gmail.com>
mihaibudiu
approved these changes
Jun 6, 2026
| } | ||
|
|
||
| /// Record that a `snapshot-*` Feldera transaction was actually started, i.e., its label was | ||
| /// propagated to a queue entry (and thence to the controller). Counted here rather than where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When introducing catchup mode, I accidentally made a change that broke the
snapshotmode, specifically, the connector didn't start a transaction to ingest a snapshot, as expected.The commit fixes, the bug, adds a test that would have caught it and also fixes the implementation of the number-of-snapshot-transactions metric, which was introduced in the catchup PR.
Describe Manual Test Plan
Tested on the medalion demo.
Checklist
Breaking Changes?
Mark if you think the answer is yes for any of these components:
Describe Incompatible Changes