[dbsp] Use serde_json to serialize data for Broadcast operator.#6395
Merged
Conversation
The Broadcast operator was using rmp_serde to serialize and deserialize data for exchange across hosts, for reasons that have been lost to the mists of time. This serialization corrupted some of our data; for example, it caused an array of integers to become an array of array of stringified integers (!). This commit fixes it by using serde_json instead of rmp_serde. Since this was the only use of rmp_serde, it drops that dependency. Thanks to @ryzhyk for debugging help. Signed-off-by: Ben Pfaff <blp@feldera.com>
ryzhyk
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Broadcast operator was using rmp_serde to serialize and deserialize data for exchange across hosts, for reasons that have been lost to the mists of time. This serialization corrupted some of our data; for example, it caused an array of integers to become an array of array of stringified integers (!).
This commit fixes it by using serde_json instead of rmp_serde. Since this was the only use of rmp_serde, it drops that dependency.
Describe Manual Test Plan
I tested that a multihost pipeline that had adaptive joins enable didn't fail immediately on startup.