[web-console] Bring back the SQL editor context menu#6379
Merged
Conversation
Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
00e9ca2 to
c24c32a
Compare
mihaibudiu
approved these changes
Jun 2, 2026
mythical-fred
approved these changes
Jun 2, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
Trivial restore of Monaco contextmenu feature — verified the Monaco features.ts manifest exposes a entry that registers the right-click action handler, so this is exactly the missing piece. mihai already approved. LGTM.
|
Apology — my review body above was mangled by a shell-substitution bug on my side (backticks in the message got command-substituted before posting). Intended text was:
Verdict (APPROVE) is unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: manual
This feature was omitted by accident when migrating the implementation of SQL editor to a separate JS project to be re-usable in the standalone self-contained Profiler HTML app