[web-console] Change private feldera-triage-plugins package injection approach#6313
Merged
Conversation
… approach Signed-off-by: Karakatiza666 <bulakh.96@gmail.com>
mythical-fred
approved these changes
May 25, 2026
mythical-fred
left a comment
There was a problem hiding this comment.
LGTM. Clean swap from package-name + node_modules symlink to absolute-path + resolve.alias. OSS path stays a no-op stub when FELDERA_PLUGINS_ENTRY is unset; server.fs.allow widening is dev-only and properly gated. Env-var rename (FELDERA_PLUGINS_MODULE → FELDERA_PLUGINS_ENTRY) is acknowledged in the PR description as a paired enterprise-repo follow-up — fine. No tests since this is build-infra for a closed-source consumer; verification happens via the enterprise build.
mihaibudiu
approved these changes
May 25, 2026
mihaibudiu
left a comment
Contributor
There was a problem hiding this comment.
I have no idea what's going on here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the compilation of web-console as a part of the Enterprise build, the enterprise repo injected the closed-source triage plugin reference to the web-console build configuration.
Previously, a plain module name ('@cloud/support-bundle-triage') was injected as FELDERA_PLUGINS_MODULE, forcing the triage plugin be discoverable inside web-console NPM scope - within feldera/node_modules. This was achieved with symlinking which was not reliable - caused build failure citing a "circular dependency" - as the triage plugin also references some JS packages in the
felderasubmodule.The fix is to inject an absolute filesystem path instead of a package name as FELDERA_PLUGINS_ENTRY, and map the triage plugin module name the web-console code imports to that file path.
When FELDERA_PLUGINS_ENTRY is unset (open-source builds), all new code paths are no-ops - a stub virtual module is emitted exactly as before.
This PR will be followed up by the PR to the enterprise repo.