Refactor selector drag behavior#800
Merged
Merged
Conversation
|
📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/selector-move |
Member
|
The polygon selector module in there was a prototype, it probably has to be rewritten. |
kushalkolar
reviewed
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #781
Refactor to move the selectors based on their original value, instead of using incremental deltas. This makes it much easier to implement natural behavior when the movement is clipped by the limits.
One question: What's up with the
PolygonSelector, I see no example of it, and it also does not implement_move_graphic.