add fft example#605
Closed
kushalkolar wants to merge 18 commits into
Closed
Conversation
Member
Author
|
I suspect CI failures are due to pygfx/wgpu-py#569 |
Member
Author
|
@clewis7 the docs build didn't finish after even 20 mins, any ideas? 🤷 will check this later |
Member
I am not seeing where it took 20 min to fail, and readthedocs looks like excessive memory consumption Weird though that CI is passing on only glfw |
Member
Author
|
I figured it out, will be fixed once pygfx/wgpu-py#587 is merged and next release of WGPU 😆 |
clewis7
previously approved these changes
Sep 17, 2024
clewis7
left a comment
Member
There was a problem hiding this comment.
checked it out and tried it, LGTM
Member
Author
|
Wait I'll fix the docs size
…On Tue, Sep 17, 2024, 3:10 PM Caitlin Lewis ***@***.***> wrote:
***@***.**** approved this pull request.
checked it out and tried it, LGTM
—
Reply to this email directly, view it on GitHub
<#605 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACHXXRFYSUBLZNNEBDUCEZTZXB5BLAVCNFSM6AAAAABOCKBSEOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMJQGYZDMNZVGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
Author
|
superseeded by #693 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rectangle_selector_fft-2024-09-11_21.02.56.mp4