Fix async and generator function tags in REPL output#178
Open
lightmare wants to merge 4 commits into
Open
Conversation
Contributor
Contributor
Author
|
Thanks for the context. So both // Node.js v16.8.0.
> f = x => x
[Function: f]
> Object.defineProperty(f, Symbol.toStringTag, { value: 'g' })
[Function: f] [g] |
Contributor
Author
|
Pushed a fix for non-matching Main (before this PR): > Object.defineProperty(x => x, Symbol.toStringTag, { value: 'barrow' });
[Function]
> Object.defineProperty(async x => x, Symbol.toStringTag, { value: 'aarrow' });
[Function]
> Object.defineProperty(function*foo() {}, Symbol.toStringTag, { value: 'gen' });
[Function: foo]
> Object.defineProperty(async function*foo() {}, Symbol.toStringTag, { value: 'agen' });
[Function: foo]
> Object.defineProperty({}, Symbol.toStringTag, { value: 'bar' });
{ }This PR: > Object.defineProperty(x => x, Symbol.toStringTag, { value: 'barrow' });
[Function (anonymous)] [barrow]
> Object.defineProperty(async x => x, Symbol.toStringTag, { value: 'aarrow' });
[AsyncFunction (anonymous)] [aarrow]
> Object.defineProperty(function*foo() {}, Symbol.toStringTag, { value: 'gen' });
[GeneratorFunction: foo] [gen]
> Object.defineProperty(async function*foo() {}, Symbol.toStringTag, { value: 'agen' });
[AsyncGeneratorFunction: foo] [agen]
> Object.defineProperty({}, Symbol.toStringTag, { value: 'bar' });
Object [bar] { }Node.js: > Object.defineProperty(x => x, Symbol.toStringTag, { value: 'barrow' });
[Function (anonymous)] [barrow]
> Object.defineProperty(async x => x, Symbol.toStringTag, { value: 'aarrow' });
[AsyncFunction (anonymous)] [aarrow]
> Object.defineProperty(function*foo() {}, Symbol.toStringTag, { value: 'gen' });
[GeneratorFunction: foo] [gen]
> Object.defineProperty(async function*foo() {}, Symbol.toStringTag, { value: 'agen' });
[AsyncGeneratorFunction: foo] [agen]
> Object.defineProperty({}, Symbol.toStringTag, { value: 'bar' });
Object [bar] {} |
707b116 to
0b90e51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously all kinds of functions were printed as
[Function: name]This PR differentiates:
[AsyncFunction: name][AsyncGeneratorFunction: name][GeneratorFunction: name]In the second commit I changed the
getObjectTaghelper function a bit. Seemed strange that it didn't returntoStringTagright away, but checkedconstructor.nameas well and used the latter if found. Or is it actually supposed to prioritizeconstructor.name? In that case, it'd make sense to simply swap the two try blocks.