Skip to content

Use posix paths for dealing with modules. - #50

Merged
rwjblue merged 1 commit into
masterfrom
dont-mix-path-seps
Oct 7, 2016
Merged

rwjblue merged 1 commit into
masterfrom
dont-mix-path-seps

Conversation

@rwjblue

@rwjblue rwjblue commented Oct 7, 2016

Copy link
Copy Markdown
Collaborator

Let the underlying subsystem deal with the path.sep differences, the logic here was incorrectly interchanging \ and / on windows.

Fixes #48.

Let the underlying subsystem deal with the `path.sep` differences, the logic here was incorrectly interchanging `\` and `/` on windows.
@rwjblue
rwjblue merged commit 3817c85 into master Oct 7, 2016
@rwjblue
rwjblue deleted the dont-mix-path-seps branch October 7, 2016 15:47
@nfc036

nfc036 commented Oct 7, 2016

Copy link
Copy Markdown
Contributor

You could also change the parameter comment from relativePath to _relativePath!?

@rwjblue

rwjblue commented Oct 7, 2016

Copy link
Copy Markdown
Collaborator Author

Yeah, true. I forgot to update the docs there. Would you mind sending a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants