Repository navigation
Fix hang when running in PhantomJS. - #43
Merged
Merged
Conversation
Collaborator
|
LOLOLOL |
Collaborator
|
expert level debugging right there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In trying to diagnose why tests hang when trying to report coverage with PhantomJS, I realized
this.responsewas coming back as a string rather than a parsed object after posting the coverage information.It turns out (as far as I can tell), Phantom just doesn't honor

xhr.responseType = 'json', and if you read it back, you just get''. To convince myself I wasn't going crazy, I captured the result of loading this page in Phantom 2.1, and it looks like this:Adding an explicit
JSON.parseavoids the early return so that the Testem callback gets invoked and everything cleans up correctly.I'm not sure how (or whether) to test this; any input on that is welcome. Thanks!