Skip to content

embroider app tests & use @embroider as peerDeps - #382

Merged
kategengler merged 3 commits into
ember-cli-code-coverage:masterfrom
AmauryD:master
Jun 8, 2023
Merged

kategengler merged 3 commits into
ember-cli-code-coverage:masterfrom
AmauryD:master

Conversation

@AmauryD

@AmauryD AmauryD commented May 20, 2023

Copy link
Copy Markdown
Contributor

Fixes #374 by using the app installed @embroider/compat.

Note: if you want i can help moving from yarn 1 to pnpm. It was a nightmare to deal with the dependencies of the test-packages.

@AmauryD AmauryD changed the title embroider app tests & use peerDeps embroider app tests & use @embroider as peerDeps May 20, 2023
@AmauryD
AmauryD force-pushed the master branch 2 times, most recently from d05bfaf to fcd1f20 Compare May 20, 2023 10:59
@rohitpaulk

Copy link
Copy Markdown

Just tested this out in our app, and it does seem to fix #374.

I was able to workaround the sub-directory github link limitation mentioned in #374 (comment) by using https://gitpkg.vercel.app/:

"ember-cli-code-coverage": "https://gitpkg.now.sh/AmauryD/ember-cli-code-coverage/packages/ember-cli-code-coverage?master"

@tniezurawski

Copy link
Copy Markdown

I'll repeat what I wrote in the issue for the visibility - I confirm the change fixes the problem for us 👍

@elidupuis

Copy link
Copy Markdown

I tested this out in our app (using the gitpkg.now.sh approach outlined above) and can also confirm that it works as expected. For reference, I also upgraded Embroider the latest 3.x versions outlined here.

"sinon": "^4.2.2"
},
"peerDependencies": {
"@embroider/compat": "^0.47.0 || ^1.0.0 || ^2.0.0 || ^3.0.0",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you loosen these to make the last >=3.0.0? That way if it happens to work with 4.0 or further, we don't have to release just to bump the peer dep?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ! Thank's for the review

Comment thread test-packages/.DS_Store Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an accidentally committed file

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is. I added .DS_Store files to gitignore

Comment thread .DS_Store Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like another DS_Store made it in

@AmauryD AmauryD Jun 8, 2023 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ! It was the last one.

image

@kategengler
kategengler merged commit 46dc079 into ember-cli-code-coverage:master Jun 8, 2023
@kategengler

Copy link
Copy Markdown
Collaborator

Thank you!

@RobbieTheWagner

Copy link
Copy Markdown
Collaborator

Fixes #374 by using the app installed @embroider/compat.

Note: if you want i can help moving from yarn 1 to pnpm. It was a nightmare to deal with the dependencies of the test-packages.

@AmauryD if the offer still stands, I would love help converting to pnpm. It seems the tests you added are failing in the master branch now, and I am not sure why. Also to note, #387 makes some embroider tweaks and I think we should probably get that in too. Would love your help getting this stuff sorted out and getting tests passing again ❤️

@AmauryD

AmauryD commented Nov 7, 2023

Copy link
Copy Markdown
Contributor Author

Fixes #374 by using the app installed @embroider/compat.
Note: if you want i can help moving from yarn 1 to pnpm. It was a nightmare to deal with the dependencies of the test-packages.

@AmauryD if the offer still stands, I would love help converting to pnpm. It seems the tests you added are failing in the master branch now, and I am not sure why. Also to note, #387 makes some embroider tweaks and I think we should probably get that in too. Would love your help getting this stuff sorted out and getting tests passing again ❤️

It will be a pleasure to help ! I'll take a look in my free time 😄

@RobbieTheWagner

Copy link
Copy Markdown
Collaborator

Thank you @AmauryD!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No coverage report generated when used with @embroider/compat@^2.1.0

6 participants