Skip to content

allow for a wider range of embroider dependencies - #379

Closed
mansona wants to merge 2 commits into
ember-cli-code-coverage:masterfrom
mansona:wider-embroider-dependency
Closed

mansona wants to merge 2 commits into
ember-cli-code-coverage:masterfrom
mansona:wider-embroider-dependency

Conversation

@mansona

@mansona mansona commented Mar 9, 2023 •

Copy link
Copy Markdown
Collaborator

This is my second attempt at fixing my tests downstream. #378 wasn't enough of a change

This PR should be ok to merge and release as a minor and shouldn't interfere with any embroider dependencies dowstream.

Note: I needed to re-role the yarn.lock file in this PR because there are some babel changes that were causing some issues and the primary advice seems to be to re-roll your lock file 🤷 babel/babel#12949

I also had to update snapshots since there was some slight change. I'm assuming this is just as a result of the yarn.lock bump 👍

@rwjblue

rwjblue commented May 1, 2023

Copy link
Copy Markdown
Collaborator

In general, this seems good to me. I'm not sure why CI didn't run though 🤔

@mansona

mansona commented Jun 28, 2023

Copy link
Copy Markdown
Collaborator Author

This is fixed in #382 👍

@mansona mansona closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants